build: Build Chrome in out_$BOARD rather than $BOARD_out.

build: Build Chrome in out_$BOARD rather than $BOARD_out.

I think that this will make ignoring the various output
directories via the Chromium repo's .gitignore a bit
cleaner.

BUG=chromium-os:7967
TEST=ran "USE='-build_tests' FEATURES='-usersandbox' CHROME_ORIGIN=LOCAL_SOURCE emerge-x86-mario chromeos-chrome" with an existing x86-mario_out directory and checked that it was renamed. ran it with build_tests enabled with an existing out_x86-mario directory.

Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=2726894

[Daniel Erat, 2010-12-03 19:36:13]

This is the same as the previous version, but in the chromiumos overlay now.

[kliegs, 2010-12-03 19:44:19]

LGTM w/nit.

As before I'm not appropriate as a "push now" reviewer.  

I've also added cmasone as a reviewer given the extensive work he's done on this
file lately.

http://codereview.chromium.org/5598002/diff/2001/chromeos-base/chromeos-chrom...
File chromeos-base/chromeos-chrome/chromeos-chrome-8.0.552.308.ebuild (right):

http://codereview.chromium.org/5598002/diff/2001/chromeos-base/chromeos-chrom...
chromeos-base/chromeos-chrome/chromeos-chrome-8.0.552.308.ebuild:376: # If
there's already a build directory in the old location, rename it to the
Keep comments <80 chars please

http://codereview.chromium.org/5598002/diff/2001/chromeos-base/chromeos-chrom...
chromeos-base/chromeos-chrome/chromeos-chrome-8.0.552.308.ebuild:378: #
TODO(derat): Remove this in January 2011.
I'd rather see this as a specific week or date.  removing this Jan 1 is
potentially troublesome given potential holiday schedules and such.
Although all removing it seems to do is cause some wasted disk space so not a
big deal if it goes early as I think on it more.

[Daniel Erat, 2010-12-03 19:50:34]

http://codereview.chromium.org/5598002/diff/2001/chromeos-base/chromeos-chrom...
File chromeos-base/chromeos-chrome/chromeos-chrome-8.0.552.308.ebuild (right):

http://codereview.chromium.org/5598002/diff/2001/chromeos-base/chromeos-chrom...
chromeos-base/chromeos-chrome/chromeos-chrome-8.0.552.308.ebuild:376: # If
there's already a build directory in the old location, rename it to the
On 2010/12/03 19:44:19, kliegs wrote:
> Keep comments <80 chars please

They are (well, one line is exactly 80 columns).  ebuilds use 4-character tabs
but Rietveld doesn't understand this.

http://codereview.chromium.org/5598002/diff/2001/chromeos-base/chromeos-chrom...
chromeos-base/chromeos-chrome/chromeos-chrome-8.0.552.308.ebuild:378: #
TODO(derat): Remove this in January 2011.
On 2010/12/03 19:44:19, kliegs wrote:
> I'd rather see this as a specific week or date.  removing this Jan 1 is
> potentially troublesome given potential holiday schedules and such.
> Although all removing it seems to do is cause some wasted disk space so not a
> big deal if it goes early as I think on it more.

I didn't add a date since it doesn't really matter when this gets removed, or
even if it gets removed.  No sense it keeping it around forever, but I've fine
with choosing some arbitrary date in February if you're worried that there are
some people who might not do any builds between now and whenever in January I
take this out.

[kliegs, 2010-12-03 20:04:41]

Whoops - I must've miscounted.  Thought I saw it just wrapping on that line.


For the removal date I probably should've just removed my comment on that.
 My initial concern went down once I realized that the impact was pretty
minimal if it was removed before someone had run it.  It might be worth a
simple note to the list so people can clean up stale directories if needed
(a few of my chrome checkouts have multiple *_out's and odds are I won't
revisit all before you'd remove this change).

On Fri, Dec 3, 2010 at 2:50 PM, <derat@chromium.org> wrote:

>
>
>
http://codereview.chromium.org/5598002/diff/2001/chromeos-base/chromeos-chrom...
> File chromeos-base/chromeos-chrome/chromeos-chrome-8.0.552.308.ebuild
> (right):
>
>
>
http://codereview.chromium.org/5598002/diff/2001/chromeos-base/chromeos-chrom...
> chromeos-base/chromeos-chrome/chromeos-chrome-8.0.552.308.ebuild:376: #
> If there's already a build directory in the old location, rename it to
> the
> On 2010/12/03 19:44:19, kliegs wrote:
>
>> Keep comments <80 chars please
>>
>
> They are (well, one line is exactly 80 columns).  ebuilds use
> 4-character tabs but Rietveld doesn't understand this.
>
>
>
>
http://codereview.chromium.org/5598002/diff/2001/chromeos-base/chromeos-chrom...
> chromeos-base/chromeos-chrome/chromeos-chrome-8.0.552.308.ebuild:378: #
> TODO(derat): Remove this in January 2011.
> On 2010/12/03 19:44:19, kliegs wrote:
>
>> I'd rather see this as a specific week or date.  removing this Jan 1
>>
> is
>
>> potentially troublesome given potential holiday schedules and such.
>> Although all removing it seems to do is cause some wasted disk space
>>
> so not a
>
>> big deal if it goes early as I think on it more.
>>
>
> I didn't add a date since it doesn't really matter when this gets
> removed, or even if it gets removed.  No sense it keeping it around
> forever, but I've fine with choosing some arbitrary date in February if
> you're worried that there are some people who might not do any builds
> between now and whenever in January I take this out.
>
>
> http://codereview.chromium.org/5598002/
>

[Daniel Erat, 2010-12-03 20:09:09]

On Fri, Dec 3, 2010 at 12:04 PM, Jonathan Kliegman <kliegs@chromium.org> wrote:
> For the removal date I probably should've just removed my comment on that.
>  My initial concern went down once I realized that the impact was pretty
> minimal if it was removed before someone had run it.  It might be worth a
> simple note to the list so people can clean up stale directories if needed
> (a few of my chrome checkouts have multiple *_out's and odds are I won't
> revisit all before you'd remove this change).

Thanks for the clarification.  I'll send a message about this.

>> http://codereview.chromium.org/5598002/
>
>

[Chris Masone, 2010-12-03 21:54:45]

I find this change compelling and filled with unearthly beauty.  It should be
committed post-haste.

[Daniel Erat, 2010-12-03 21:57:27]

If only I could expect such floridity from all reviews.  Thanks, committing.

On Fri, Dec 3, 2010 at 1:54 PM,  <cmasone@chromium.org> wrote:
> I find this change compelling and filled with unearthly beauty.  It should
> be
> committed post-haste.
>
> http://codereview.chromium.org/5598002/
>