Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 5597004: Create the latest_download dir if it doesn't exist. (Closed)

Created:
10 years ago by dgarrett
Modified:
9 years, 7 months ago
Reviewers:
sosa
CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa
Visibility:
Public.

Description

Create the latest_download dir if it doesn't exist. I started to use /tmp, but it doesn't exist both inside and outside of the chroot. Using a consistent name like this has the advantage that the files will be cached and not redownloaded every time. Well, except on the build servers that wipe the related directories between builds. Change-Id: I58b42d9f1bd18cc4eb44043ed2436d4ffa482767 BUG=chromium-os:10012 TEST= Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=e55c89a

Patch Set 1 #

Total comments: 2

Patch Set 2 : Move download folder to crosutils. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M bin/cros_au_test_harness.py View 1 3 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
dgarrett
10 years ago (2010-12-06 19:39:40 UTC) #1
sosa
LGTM but can you move it? http://codereview.chromium.org/5597004/diff/1/bin/cros_au_test_harness.py File bin/cros_au_test_harness.py (right): http://codereview.chromium.org/5597004/diff/1/bin/cros_au_test_harness.py#newcode53 bin/cros_au_test_harness.py:53: os.makedirs(self.download_folder) Can you ...
10 years ago (2010-12-06 19:42:15 UTC) #2
dgarrett
http://codereview.chromium.org/5597004/diff/1/bin/cros_au_test_harness.py File bin/cros_au_test_harness.py (right): http://codereview.chromium.org/5597004/diff/1/bin/cros_au_test_harness.py#newcode53 bin/cros_au_test_harness.py:53: os.makedirs(self.download_folder) On 2010/12/06 19:42:15, sosa wrote: > Can you ...
10 years ago (2010-12-06 19:51:28 UTC) #3
sosa
Suggested moving it to be consistent with the builders workflow. On Mon, Dec 6, 2010 ...
10 years ago (2010-12-06 22:48:27 UTC) #4
dgarrett
Just to be certain, is this what you mean?
10 years ago (2010-12-06 23:27:22 UTC) #5
sosa
10 years ago (2010-12-06 23:57:52 UTC) #6
Yes, LGTM

On Mon, Dec 6, 2010 at 3:27 PM,  <dgarrett@chromium.org> wrote:
> Just to be certain, is this what you mean?
>
> http://codereview.chromium.org/5597004/
>

Powered by Google App Engine
This is Rietveld 408576698