Issue 5595004: Have upload_prebuilts respect the debug flag.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5595004: Have upload_prebuilts respect the debug flag. (Closed)

Created:
10 years ago by sosa

Modified:
9 years, 6 months ago

Reviewers:
davidjames

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa

Base URL:
http://git.chromium.org/git/crosutils.git@master

Visibility:
Public.

Description

Have upload_prebuilts respect the debug flag. Chrome PFQ right now is uploading prebuilts which wasn't meant to happen :( Change-Id: I502a0621a6c9f655e5a3f890dd79e00652925902 BUG=chromium-os:8693 TEST=Ran cbuildbot with --debug Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=1a4a966

Patch Set 1 #

Created: 10 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	bin/cbuildbot.py	View		1 chunk	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

davidjames

10 years ago (2010-12-04 00:26:16 UTC) #2

LGTM, but there's still some TODOs here for future:
  1) We should teach prebuilt.py to have a dryrun mode where it doesn't actually
upload the prebuilts
  2) We should setup another mechanism for disabling prebuilts on the chrome bot
and/or coordinating with preflight to publish prebuilts atomically

Expand Messages | Collapse Messages