DOMUI Prefs: Add a subpage for startup page management.

chrome/browser/resources/options/browser_options.js

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('options', function() {
   const OptionsPage = options.OptionsPage;
   const ArrayDataModel = cr.ui.ArrayDataModel;
   const ListSelectionModel = cr.ui.ListSelectionModel;
 
   //
@@ skipping 23 matching lines @@
     },
 
     /**
      * Initialize BrowserOptions page.
      */
     initializePage: function() {
       // Call base class implementation to start preference initialization.
       OptionsPage.prototype.initializePage.call(this);
 
       // Wire up controls.
-      $('startupAddButton').onclick = function(event) {
-        OptionsPage.showOverlay('addStartupPageOverlay');
-      };
-      $('startupRemoveButton').onclick =
-          this.removeSelectedStartupPages_.bind(this);
       $('startupUseCurrentButton').onclick = function(event) {
         chrome.send('setStartupPagesToCurrentPages');
       };
+      $('startupPageManagerButton').onclick = function(event) {
+        OptionsPage.showPageByName('startupPages');
+      };
       $('defaultSearchManageEnginesButton').onclick = function(event) {
         OptionsPage.showPageByName('searchEngines');
         chrome.send('coreOptionsUserMetricsAction',
             ['Options_ManageSearchEngines']);
       };
       $('instantEnableCheckbox').onclick = function(event) {
         var alreadyConfirmed = $('instantDialogShown').checked;
 
         if (this.checked && !alreadyConfirmed) {
           // Leave disabled for now. The PrefCheckbox handler already set it to
@@ skipping 16 matching lines @@
           if (document.activeElement == homepageField)
             homepageField.blur();
           });
 
       if (!cr.isChromeOS) {
         $('defaultBrowserUseAsDefaultButton').onclick = function(event) {
           chrome.send('becomeDefaultBrowser');
         };
       }
 
-      var list = $('startupPages');
+      var list = $('startupPagesShortList');
       options.browser_options.StartupPageList.decorate(list);
       list.autoExpands = true;
       list.selectionModel = new ListSelectionModel;
 
-      list.selectionModel.addEventListener(
-          'change', this.updateRemoveButtonState_.bind(this));
-
       // Check if we are in the guest mode.
       if (cr.commandLine.options['--bwsi']) {
-        // Disable input and button elements under the startup section.
-        var elements = $('startupSection').querySelectorAll('input, button');
+        // Disable all controls under the startup section.
+        var elements =
+            $('startupSection').querySelectorAll('input, button, list');
         for (var i = 0; i < elements.length; i++) {
           elements[i].disabled = true;
           elements[i].manually_disabled = true;
         }
       } else {
         // Initialize control enabled states.
         Preferences.getInstance().addEventListener('session.restore_on_startup',
             this.updateCustomStartupPageControlStates_.bind(this));
         Preferences.getInstance().addEventListener('homepage_is_newtabpage',
             this.handleHomepageIsNewTabPageChange_.bind(this));
         Preferences.getInstance().addEventListener('homepage',
             this.handleHomepageChange_.bind(this));
 
         this.updateCustomStartupPageControlStates_();
       }
-
-      // Remove Windows-style accelerators from button labels.
-      // TODO(stuartmorgan): Remove this once the strings are updated.
-      $('startupAddButton').textContent =
-          localStrings.getStringWithoutAccelerator('startupAddButton');
-      $('startupRemoveButton').textContent =
-          localStrings.getStringWithoutAccelerator('startupRemoveButton');
     },
 
     /**
      * Update the Default Browsers section based on the current state.
      * @private
      * @param {string} statusString Description of the current default state.
      * @param {boolean} isDefault Whether or not the browser is currently
      *     default.
      * @param {boolean} canBeDefault Whether or not the browser can be default.
      */
@@ skipping 45 matching lines @@
     shouldEnableCustomStartupPageControls_: function(pages) {
       return $('startupShowPagesButton').checked;
     },
 
     /**
      * Updates the startup pages list with the given entries.
      * @private
      * @param {Array} pages List of startup pages.
      */
     updateStartupPages_: function(pages) {
-      // TODO(stuartmorgan): Once the sub-page is done, handle 0 and > 10 pages.
-      $('startupPages').dataModel = new ArrayDataModel(pages);
-      this.updateRemoveButtonState_();
+      var list = $('startupPagesShortList');
+      list.dataModel = new ArrayDataModel(pages);
+      if (pages.length > 0 && pages.length <= 10) {
+        list.classList.remove("hidden");
+        $('startupPageManagement').classList.add('fullView');
+        $('startupShowPagesLabel').textContent =
+            localStrings.getStringWithoutAccelerator('startupShowPages');
+      } else {
+        list.classList.add("hidden");
+        $('startupPageManagement').classList.remove('fullView');
+        $('startupShowPagesLabel').textContent =
+            localStrings.getStringWithoutAccelerator('startupShowManyPages');
+      }
     },
 
     /**
      * Handles change events of the radio button 'homepageUseURLButton'.
      * @private
      * @param {event} change event.
      */
     handleHomepageUseURLButtonChange_: function(event) {
       Preferences.setBooleanPref('homepage_is_newtabpage', false);
     },
@@ skipping 141 matching lines @@
                 !this.homepage_is_newtabpage_pref_.managed));
     },
 
     /**
      * Sets the enabled state of the custom startup page list controls
      * based on the current startup radio button selection.
      * @private
      */
     updateCustomStartupPageControlStates_: function() {
       var disable = !this.shouldEnableCustomStartupPageControls_();
-      $('startupPages').disabled = disable;
-      $('startupAddButton').disabled = disable;
+      $('startupPagesShortList').disabled = disable;
       $('startupUseCurrentButton').disabled = disable;
-      this.updateRemoveButtonState_();
+      $('startupPageManagerButton').disabled = disable;
     },
 
     /**
-     * Sets the enabled state of the startup page Remove button based on
-     * the current selection in the startup pages list.
-     * @private
-     */
-    updateRemoveButtonState_: function() {
-      var groupEnabled = this.shouldEnableCustomStartupPageControls_();
-      $('startupRemoveButton').disabled = !groupEnabled ||
-          ($('startupPages').selectionModel.selectedIndex == -1);
-    },
-
-    /**
      * Removes the selected startup pages.
      * @private
      */
     removeSelectedStartupPages_: function() {
       var selections =
-          $('startupPages').selectionModel.selectedIndexes.map(String);
+          $('startupPagesShortList').selectionModel.selectedIndexes.map(String);
       chrome.send('removeStartupPages', selections);
     },
 
     /**
      * Adds the given startup page at the current selection point.
      * @private
      */
     addStartupPage_: function(url) {
-      var firstSelection = $('startupPages').selectionModel.selectedIndex;
+      var firstSelection =
+          $('startupPagesShortList').selectionModel.selectedIndex;
       chrome.send('addStartupPage', [url, String(firstSelection)]);
     },
 
     /**
      * Set the default search engine based on the popup selection.
      */
     setDefaultSearchEngine: function() {
       var engineSelect = $('defaultSearchEngine');
       var selectedIndex = engineSelect.selectedIndex;
       if (selectedIndex >= 0) {
@@ skipping 11 matching lines @@
                                                               canBeDefault);
     }
   };
 
   BrowserOptions.updateSearchEngines = function(engines, defaultValue) {
     BrowserOptions.getInstance().updateSearchEngines_(engines, defaultValue);
   };
 
   BrowserOptions.updateStartupPages = function(pages) {
     BrowserOptions.getInstance().updateStartupPages_(pages);
+    StartupPageManager.getInstance().updateStartupPages_(pages);
   };
 
   BrowserOptions.addStartupPage = function(url) {
     BrowserOptions.getInstance().addStartupPage_(url);
   };
 
   // Export
   return {
     BrowserOptions: BrowserOptions
   };
 
 });