DOMUI Prefs: Add a subpage for startup page management.

DOMUI Prefs: Add a subpage for startup page management.

This still uses the old-style controls for adding and removing entries, but it moves them to the sub-page as an incremental step toward the mocks.

BUG=63817
TEST=The new Manage Startup Pages button in the Basics section should open a subpage where pages can be added and removed.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=68755

[csilv, 2010-12-08 23:46:12]

LGTM

http://codereview.chromium.org/5594006/diff/2001/chrome/browser/dom_ui/option...
File chrome/browser/dom_ui/options/startup_page_manager_handler.h (right):

http://codereview.chromium.org/5594006/diff/2001/chrome/browser/dom_ui/option...
chrome/browser/dom_ui/options/startup_page_manager_handler.h:10: class
KeywordEditorController;
This appears to be unused.

http://codereview.chromium.org/5594006/diff/2001/chrome/browser/resources/opt...
File chrome/browser/resources/options/browser_options.html (right):

http://codereview.chromium.org/5594006/diff/2001/chrome/browser/resources/opt...
chrome/browser/resources/options/browser_options.html:1: <div class="page
hidden" id="browserPage">
Since you're in this file, can you swap the order of the class/id attributes? 
Trying to always show id first for consistency.

http://codereview.chromium.org/5594006/diff/2001/chrome/browser/resources/opt...
File chrome/browser/resources/options/startup_page_manager.html (right):

http://codereview.chromium.org/5594006/diff/2001/chrome/browser/resources/opt...
chrome/browser/resources/options/startup_page_manager.html:1: <div class="page
hidden" id="startupPageManagerPage">
switch order of id/class tags.

http://codereview.chromium.org/5594006/diff/2001/chrome/browser/resources/opt...
File chrome/browser/resources/options/startup_page_manager.js (right):

http://codereview.chromium.org/5594006/diff/2001/chrome/browser/resources/opt...
chrome/browser/resources/options/startup_page_manager.js:55: * @private
nit, move @private line to bottom of comment block.  not explicitly listed in
guideline, but follows the pattern.

[stuartmorgan, 2010-12-09 19:30:08]

http://codereview.chromium.org/5594006/diff/2001/chrome/browser/dom_ui/option...
File chrome/browser/dom_ui/options/startup_page_manager_handler.h (right):

http://codereview.chromium.org/5594006/diff/2001/chrome/browser/dom_ui/option...
chrome/browser/dom_ui/options/startup_page_manager_handler.h:10: class
KeywordEditorController;
On 2010/12/08 23:46:12, csilv wrote:
> This appears to be unused.

Done.

http://codereview.chromium.org/5594006/diff/2001/chrome/browser/resources/opt...
File chrome/browser/resources/options/browser_options.html (right):

http://codereview.chromium.org/5594006/diff/2001/chrome/browser/resources/opt...
chrome/browser/resources/options/browser_options.html:1: <div class="page
hidden" id="browserPage">
On 2010/12/08 23:46:12, csilv wrote:
> Since you're in this file, can you swap the order of the class/id attributes? 
> Trying to always show id first for consistency.

Done.

http://codereview.chromium.org/5594006/diff/2001/chrome/browser/resources/opt...
File chrome/browser/resources/options/startup_page_manager.html (right):

http://codereview.chromium.org/5594006/diff/2001/chrome/browser/resources/opt...
chrome/browser/resources/options/startup_page_manager.html:1: <div class="page
hidden" id="startupPageManagerPage">
On 2010/12/08 23:46:12, csilv wrote:
> switch order of id/class tags.

Done.

http://codereview.chromium.org/5594006/diff/2001/chrome/browser/resources/opt...
File chrome/browser/resources/options/startup_page_manager.js (right):

http://codereview.chromium.org/5594006/diff/2001/chrome/browser/resources/opt...
chrome/browser/resources/options/startup_page_manager.js:55: * @private
On 2010/12/08 23:46:12, csilv wrote:
> nit, move @private line to bottom of comment block.  not explicitly listed in
> guideline, but follows the pattern.

Done.