Changed interface to preparser to not require pushback support.

Changed interface to preparser to not require pushback support.
Changed implementation of pushback in preparer character stream.
Removed assert that isn't satisfied by in test-cases, but only by the real code.
Make preparser compile again.

[Lasse Reichstein, 2010-12-08 09:28:56]

http://codereview.chromium.org/5593004/diff/1/src/scanner-base.cc
File src/scanner-base.cc (left):

http://codereview.chromium.org/5593004/diff/1/src/scanner-base.cc#oldcode515
src/scanner-base.cc:515: ASSERT_EQ(Token::RBRACE, next_.token);
This only holds in real use. The unit-tests are more random.

[Rico, 2010-12-08 09:46:25]

LGTM

http://codereview.chromium.org/5593004/diff/1/preparser/preparser-process.cc
File preparser/preparser-process.cc (right):

http://codereview.chromium.org/5593004/diff/1/preparser/preparser-process.cc#...
preparser/preparser-process.cc:153: // Preparse stdin and output result on
stdout.
I guess the comment is a bit wrong now, input does not have to be stdin

http://codereview.chromium.org/5593004/diff/1/preparser/preparser-process.cc#...
preparser/preparser-process.cc:197: if (!file) return EXIT_FAILURE;
Wy do we do this check that the file exists and can be read, we do not use it
for anything right?

http://codereview.chromium.org/5593004/diff/1/src/preparser-api.cc
File src/preparser-api.cc (right):

http://codereview.chromium.org/5593004/diff/1/src/preparser-api.cc#newcode51
src/preparser-api.cc:51: * an external buffer is allocated/reused to hold
further pushbacks, and
and but -> and

[Lasse Reichstein, 2010-12-08 10:05:36]

http://codereview.chromium.org/5593004/diff/1/preparser/preparser-process.cc
File preparser/preparser-process.cc (right):

http://codereview.chromium.org/5593004/diff/1/preparser/preparser-process.cc#...
preparser/preparser-process.cc:153: // Preparse stdin and output result on
stdout.
Good catch. Fixed.

http://codereview.chromium.org/5593004/diff/1/preparser/preparser-process.cc#...
preparser/preparser-process.cc:197: if (!file) return EXIT_FAILURE;
We check the returns of reads and writes as well.

http://codereview.chromium.org/5593004/diff/1/src/preparser-api.cc
File src/preparser-api.cc (right):

http://codereview.chromium.org/5593004/diff/1/src/preparser-api.cc#newcode51
src/preparser-api.cc:51: * an external buffer is allocated/reused to hold
further pushbacks, and
On 2010/12/08 09:46:25, Rico wrote:
> and but -> and

Done.