Disable SPDY by default as a test to see if heap corruption goes away.

Disable SPDY by default as a test to see if heap corruption goes away.

Will re-enable after a canary goes out with this off.

BUG=65948
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=68696

[willchan no longer on Chromium, 2010-12-09 00:51:18]

I haven't run this through trybots yet, but I think that if we disable it this
way, it should still work for our net_unittests.

Remind me to re-enable later :)

[mbelshe, 2010-12-09 00:56:35]

LGTM

On Wed, Dec 8, 2010 at 4:51 PM, <willchan@chromium.org> wrote:

> Reviewers: Mike Belshe,
>
> Message:
> I haven't run this through trybots yet, but I think that if we disable it
> this
> way, it should still work for our net_unittests.
>
> Remind me to re-enable later :)
>
> Description:
> Disable SPDY by default as a test to see if heap corruption goes away.
>
> Will re-enable after a canary goes out with this off.
>
> BUG=65948
> TEST=none
>
> Please review this at http://codereview.chromium.org/5592009/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files:
>  M net/http/http_network_layer.cc
>  M net/http/http_stream_factory.cc
>
>
> Index: net/http/http_network_layer.cc
> diff --git a/net/http/http_network_layer.cc
> b/net/http/http_network_layer.cc
> index
>
3da23c2643dff1272d48b8199adf29050c0bdac2..7ce15682ce6927c6ba0471d2db865b62f94b6400
> 100644
> --- a/net/http/http_network_layer.cc
> +++ b/net/http/http_network_layer.cc
> @@ -258,5 +258,10 @@ void HttpNetworkLayer::EnableSpdy(const std::string&
> mode) {
>       LOG(DFATAL) << "Unrecognized spdy option: " << option;
>     }
>   }
> +
> +  // TODO(willchan): Re-enable SPDY after a canary release goes out
> +  // with SPDY off.
> +  HttpStreamFactory::set_spdy_enabled(false);
>  }
> +
>  }  // namespace net
> Index: net/http/http_stream_factory.cc
> diff --git a/net/http/http_stream_factory.cc
> b/net/http/http_stream_factory.cc
> index
>
e30c0c550080ca19c7abb90d483d42739dcc4641..cb1265b4e157647a9451de314efbcf9fad86a316
> 100644
> --- a/net/http/http_stream_factory.cc
> +++ b/net/http/http_stream_factory.cc
> @@ -165,4 +165,3 @@ void HttpStreamFactory::OnPreconnectsComplete(
>  }
>
>  }  // namespace net
> -
>
>
>