Factor out some SSL specific configs, and add another reference to /var/run t...

Adding SSL mutex specification to a local file, to stop relying on a mutable directory
in the root.

[Peter Mayo, 2010-12-09 23:08:39]

Ping?

While this may not be sufficient to eliminate all failures in the FYI builder I
am looking at, but it makes dom_checker_ui pass, and should not hurt any
successful builders.

I.e. if you a2dismod ssl you should get failures for ssl tests, not fail to
start messages for all apache tests.

[tony, 2010-12-09 23:25:00]

http://codereview.chromium.org/5591007/diff/4001/tools/python/google/platform...
File tools/python/google/platform_utils_linux.py (right):

http://codereview.chromium.org/5591007/diff/4001/tools/python/google/platform...
tools/python/google/platform_utils_linux.py:84: ssl_enabled =
os.path.exists('/etc/apache2/mods-enabled/ssl.conf')
Is this file in the same location on hardy and lucid?

http://codereview.chromium.org/5591007/diff/4001/tools/python/google/platform...
tools/python/google/platform_utils_linux.py:97:
"shmcb:"+os.path.join(output_dir, "ssl_scache", "(512000)"),
Nit: spaces around the +.  Is it standard to put (512000) in the path?

[nsylvain, 2010-12-10 00:31:42]

Have you tried to make it fail when ssl is not enabled?  Is the error verbose
enough to understand?

As for /var/run , is your ssl_scache change going to fix this?

Thanks! 

LGTM

[Peter Mayo, 2010-12-10 16:05:15]

On 2010/12/09 23:25:00, tony wrote:
>
http://codereview.chromium.org/5591007/diff/4001/tools/python/google/platform...
> tools/python/google/platform_utils_linux.py:84: ssl_enabled =
> os.path.exists('/etc/apache2/mods-enabled/ssl.conf')
> Is this file in the same location on hardy and lucid?

I believe so ( from
http://packages.ubuntu.com/hardy/i386/apache2.2-common/filelist and the way that
a2enmod works)

> 
>
http://codereview.chromium.org/5591007/diff/4001/tools/python/google/platform...
> tools/python/google/platform_utils_linux.py:97:
> "shmcb:"+os.path.join(output_dir, "ssl_scache", "(512000)"),
> Nit: spaces around the +.  Is it standard to put (512000) in the path?

I copied the value from the .conf file I was overriding and changed the path. 
And oops, it belongs outside the os.path.join because it does not want a path
separator.

[Peter Mayo, 2010-12-10 16:32:31]

On 2010/12/10 00:31:42, nsylvain wrote:
> Have you tried to make it fail when ssl is not enabled?  Is the error verbose
> enough to understand?

In my test environment the errors do not change between with & wihtout SSL.  I
haven't found a good bellweather, yet. I am still struggling with the
browser_tests failures - the error messages have not revealed a cause either
way, and I haven't found what they are actually trying to start and failing.
> 
> As for /var/run , is your ssl_scache change going to fix this?

Similar answer, 

http://build.chromium.org/p/chromium.fyi/waterfall?builder=Chromium+Linux+Tou...

Shows failures in 3 suites.  This builder does NOT have a writable
/var/run/apache2, nor SSL enabled.  With this change, I expect dom_checker_tests
to pass, and ui_tests and browser tests to still have the same failures.

> LGTM

[Peter Mayo, 2010-12-14 16:45:04]

On 2010/12/10 16:05:15, Peter Mayo wrote:
> On 2010/12/09 23:25:00, tony wrote:
> >
>
http://codereview.chromium.org/5591007/diff/4001/tools/python/google/platform...
> > tools/python/google/platform_utils_linux.py:84: ssl_enabled =
> > os.path.exists('/etc/apache2/mods-enabled/ssl.conf')
> > Is this file in the same location on hardy and lucid?
> 
> I believe so ( from
> http://packages.ubuntu.com/hardy/i386/apache2.2-common/filelist and the way
that
> a2enmod works)
> 
> > 
> >
>
http://codereview.chromium.org/5591007/diff/4001/tools/python/google/platform...
> > tools/python/google/platform_utils_linux.py:97:
> > "shmcb:"+os.path.join(output_dir, "ssl_scache", "(512000)"),
> > Nit: spaces around the +.  Is it standard to put (512000) in the path?
> 
> I copied the value from the .conf file I was overriding and changed the path. 
> And oops, it belongs outside the os.path.join because it does not want a path
> separator.

Ping - been tested and sitting here a while.

[tony, 2010-12-14 20:02:54]

lgtm2

[nsylvain, 2010-12-14 20:59:09]

LGTM