Add an API to allow JavaScript to determine the framerate of individual dynam...

Add an API to allow JavaScript to determine the framerate of individual dynamic textures.

TEST=loaded O3D on a test page on Linux and used the new API to display the framerate
BUG=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=68379

[zhurunz, 2010-12-04 01:29:49]

http://codereview.chromium.org/5591006/diff/1/core/cross/texture_base.cc
File core/cross/texture_base.cc (right):

http://codereview.chromium.org/5591006/diff/1/core/cross/texture_base.cc#newc...
core/cross/texture_base.cc:69: last_render_frame_count_ =
renderer_->render_frame_count();
Maybe check null on renderer just to be safe.
I am not sure if we will always get renderer here.

http://codereview.chromium.org/5591006/diff/1/core/cross/texture_base.cc#newc...
core/cross/texture_base.cc:79: render_count_++;
same as above.

http://codereview.chromium.org/5591006/diff/1/core/cross/texture_base.h
File core/cross/texture_base.h (right):

http://codereview.chromium.org/5591006/diff/1/core/cross/texture_base.h#newco...
core/cross/texture_base.h:158: 
static is better?

[Tristan Schmelcher 2, 2010-12-06 18:44:59]

http://codereview.chromium.org/5591006/diff/1/core/cross/texture_base.cc
File core/cross/texture_base.cc (right):

http://codereview.chromium.org/5591006/diff/1/core/cross/texture_base.cc#newc...
core/cross/texture_base.cc:69: last_render_frame_count_ =
renderer_->render_frame_count();
On 2010/12/04 01:29:49, zhurunz wrote:
> Maybe check null on renderer just to be safe.
> I am not sure if we will always get renderer here.

It's guaranteed to be there because the Renderer provides the factory methods
for creating Texture objects, so you can't have a Texture object if you don't
already have a Renderer.

http://codereview.chromium.org/5591006/diff/1/core/cross/texture_base.h
File core/cross/texture_base.h (right):

http://codereview.chromium.org/5591006/diff/1/core/cross/texture_base.h#newco...
core/cross/texture_base.h:158: 
On 2010/12/04 01:29:49, zhurunz wrote:
> static is better?

Static won't work. Technically it's not a global instance--there's just only one
per ServiceLocator. The ServiceLocator is basically a container for singleton
instances, so that you can get all the benefits of singletons but still be able
to have multiple independent copies of the program in the same address space.
Since some browsers have in-proc plugins, there may actually be more than one
Renderer in the process, so we can't use a single static field.

I've removed the comment to avoid confusion.

[zhurunz, 2010-12-06 20:07:57]

LGTM