Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 5591004: glue: use string16 in place of wstring for Unicode text (Closed)

Created:
10 years ago by Evan Martin
Modified:
9 years, 7 months ago
Reviewers:
tony, viettrungluu
CC:
chromium-reviews, pam+watch_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

glue: use string16 in place of wstring for Unicode text BUG=23581 TEST=compiles Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=68208

Patch Set 1 #

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -37 lines) Patch
M webkit/glue/bookmarklet_unittest.cc View 1 4 chunks +9 lines, -9 lines 0 comments Download
M webkit/glue/cpp_bound_class_unittest.cc View 1 2 chunks +4 lines, -2 lines 0 comments Download
M webkit/glue/mimetype_unittest.cc View 1 4 chunks +6 lines, -6 lines 0 comments Download
M webkit/glue/webkit_glue.h View 1 chunk +3 lines, -3 lines 0 comments Download
M webkit/glue/webkit_glue.cc View 2 chunks +11 lines, -11 lines 0 comments Download
M webkit/tools/test_shell/test_shell.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/tools/test_shell/test_shell.cc View 3 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Evan Martin
10 years ago (2010-12-03 19:50:33 UTC) #1
tony
LGTM
10 years ago (2010-12-03 19:58:38 UTC) #2
viettrungluu
10 years ago (2010-12-03 20:00:26 UTC) #3
Damn that Tony guy is fast.

Powered by Google App Engine
This is Rietveld 408576698