Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(547)

Issue 559002: Add codereview.settings to depot_tools. (Closed)

Created:
10 years, 10 months ago by M-A Ruel
Modified:
9 years, 7 months ago
Reviewers:
Evan Martin
CC:
chromium-reviews
Visibility:
Public.

Description

Add codereview.settings to depot_tools. I'm doing this while trying to figure out the best way to make git-cl auto-configure itself on first use, including automatic presubmit scripts hook setup. TEST=none BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=37709

Patch Set 1 #

Patch Set 2 : Removed STATUS #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
A codereview.settings View 1 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
M-A Ruel
10 years, 10 months ago (2010-02-01 18:14:58 UTC) #1
Evan Martin
LGTM, but I think the "STATUS" url thing is obsolete (since the precommit hooks now ...
10 years, 10 months ago (2010-02-01 18:19:57 UTC) #2
Evan Martin
BTW since msb forked git-cl I guess you can implement this stuff whatever way seems ...
10 years, 10 months ago (2010-02-01 18:20:37 UTC) #3
M-A Ruel
On 2010/02/01 18:20:37, Evan Martin wrote: > BTW since msb forked git-cl I guess you ...
10 years, 10 months ago (2010-02-01 18:28:47 UTC) #4
Evan Martin
10 years, 10 months ago (2010-02-01 19:13:26 UTC) #5
yes

Powered by Google App Engine
This is Rietveld 408576698