Index: WebCore/ChangeLog |
=================================================================== |
--- WebCore/ChangeLog (revision 73369) |
+++ WebCore/ChangeLog (working copy) |
@@ -2,6 +2,427 @@ |
Reviewed by Darin Adler. |
+ REGRESSION(r71934): input event fires twice when editing text inside a text input. |
+ https://bugs.webkit.org/show_bug.cgi?id=50477 |
+ |
+ Now that events escape the shadow DOM boundary, the input event is fired twice |
+ for each input, once triggered by editing, once triggered by value change. |
+ |
+ Test: fast/forms/text-input-event.html |
+ |
+ * dom/InputElement.cpp: |
+ (WebCore::InputElement::setValueFromRenderer): Added a check to ensure editable fields |
+ don't fire an extra input event. |
+ |
+2010-12-03 Sheriff Bot <webkit.review.bot@gmail.com> |
+ |
+ Unreviewed, rolling out r73302. |
+ http://trac.webkit.org/changeset/73302 |
+ https://bugs.webkit.org/show_bug.cgi?id=50499 |
+ |
+ Causes crashes in debug LayoutTests (Requested by xan_ on |
+ #webkit). |
+ |
+ * accessibility/AccessibilityRenderObject.cpp: |
+ (WebCore::AccessibilityRenderObject::renderParentObject): |
+ (WebCore::AccessibilityRenderObject::addChildren): |
+ * accessibility/AccessibilityRenderObject.h: |
+ * accessibility/chromium/AccessibilityObjectChromium.cpp: |
+ (WebCore::AccessibilityObject::accessibilityIgnoreAttachment): |
+ |
+2010-12-01 Ilya Tikhonovsky <loislo@chromium.org> |
+ |
+ Reviewed by Pavel Feldman. |
+ |
+ Web Inspector: Inspector protocol cleanup task. |
+ |
+ The patch has just small renames and adjustments for the protocol things. |
+ 'handler' keyword in idl file was replaced with 'domain'. |
+ 'domain' property was assigned for the each backend to frontend messages. |
+ At the next step WebInspector wrapper functions will be removed and 'agents' will be called directly. |
+ |
+ https://bugs.webkit.org/show_bug.cgi?id=50337 |
+ |
+ * inspector/CodeGeneratorInspector.pm: |
+ * inspector/Inspector.idl: |
+ * inspector/front-end/inspector.js: |
+ (WebInspector_syncDispatch): |
+ |
+2010-12-03 Alexander Pavlov <apavlov@chromium.org> |
+ |
+ Reviewed by Yury Semikhatsky. |
+ |
+ Web Inspector: Duplicate "!important" for !important properties displayed in the Styles pane |
+ https://bugs.webkit.org/show_bug.cgi?id=50460 |
+ |
+ * inspector/front-end/StylesSidebarPane.js: |
+ * inspector/front-end/inspector.css: |
+ |
+2010-12-03 Xan Lopez <xlopez@igalia.com> |
+ |
+ Unreviewed build fix. |
+ |
+ The JS code generator includes headers unconditionally, so we need |
+ to generate them unconditionally and disable the feature. The |
+ WebAudio files hadn't been added to our sources list. |
+ |
+ * GNUmakefile.am: |
+ |
+2010-12-03 Patrick Gansterer <paroga@webkit.org> |
+ |
+ Unreviewed build fix. |
+ |
+ Try to fix EFL build after r73273. |
+ |
+ * CMakeLists.txt: |
+ |
+2010-12-03 Chris Guillory <chris.guillory@google.com> |
+ |
+ Reviewed by Chris Fleizach. |
+ |
+ Include the FrameView widget of a RenderWidget in the accessibility tree. |
+ https://bugs.webkit.org/show_bug.cgi?id=49106 |
+ |
+ Include render widget children in the accessibility tree for not mac webkit ports. |
+ |
+ * accessibility/AccessibilityRenderObject.cpp: |
+ (WebCore::AccessibilityRenderObject::renderParentObject): |
+ (WebCore::AccessibilityRenderObject::addChildren): |
+ (WebCore::AccessibilityRenderObject::addRenderWidgetChildren): |
+ * accessibility/AccessibilityRenderObject.h: |
+ * accessibility/chromium/AccessibilityObjectChromium.cpp: |
+ (WebCore::AccessibilityObject::accessibilityIgnoreAttachment): |
+ |
+2010-11-30 Abhishek Arya <inferno@chromium.org> |
+ |
+ Reviewed by Dave Hyatt. |
+ |
+ Don't clone an anonymous block, instead create a new one in splitBlocks. Also, |
+ when beforeChild is not in one of our children, then do the processing first |
+ to get its anonymous container before calling splitBlocks. |
+ https://bugs.webkit.org/show_bug.cgi?id=49928 |
+ |
+ Tests: fast/multicol/span/anonymous-before-child-parent-crash.html |
+ fast/multicol/span/anonymous-split-block-crash.html |
+ |
+ * rendering/RenderBlock.cpp: |
+ (WebCore::RenderBlock::splitBlocks): |
+ (WebCore::RenderBlock::addChildIgnoringAnonymousColumnBlocks): |
+ |
+2010-12-03 Mark Rowe <mrowe@apple.com> |
+ |
+ Reviewed by Eric Seidel. |
+ |
+ Animated GIF animates much more slowly in Safari than Firefox |
+ <rdar://problem/7689300> / <http://webkit.org/b/26455> |
+ |
+ Adopt Firefox's behavior for frame duration clamping. Images that specify a frame duration |
+ of <= 10ms are treated as having a frame duration of 100ms, while all other images use the |
+ frame duration that they specify. |
+ |
+ ImageIO currently implements its own clamping of frame durations (<rdar://problem/7689297>) |
+ which will result in this change having no observable effect on platforms where it is used |
+ until an updated version of ImageIO becomes available. |
+ |
+ * platform/graphics/ImageSource.cpp: |
+ (WebCore::ImageSource::frameDurationAtIndex): Update the formatting of the comment and style |
+ of the code to match that in ImageSourceCG. |
+ * platform/graphics/cg/ImageSourceCG.cpp: |
+ (WebCore::ImageSource::frameDurationAtIndex): |
+ |
+2010-12-03 Chris Rogers <crogers@google.com> |
+ |
+ Unreviewed build fix. |
+ |
+ Fix M_E compile error on Chromium Win |
+ https://bugs.webkit.org/show_bug.cgi?id=50479 |
+ |
+ * platform/audio/AudioUtilities.cpp: |
+ (WebCore::AudioUtilities::discreteTimeConstantForSampleRate): |
+ |
+2010-12-03 Chris Rogers <crogers@google.com> |
+ |
+ Unreviewed build fix. |
+ |
+ Try to fix GTK build due to recent web audio makefile changes (disable ENABLE_WEB_AUDIO explicitly) |
+ https://bugs.webkit.org/show_bug.cgi?id=50478 |
+ |
+ * GNUmakefile.am: |
+ |
+2010-12-03 Simon Fraser <simon.fraser@apple.com> |
+ |
+ Reviewed by Dirk Schulze. |
+ |
+ Clean up some text-related code on GraphicsContext |
+ https://bugs.webkit.org/show_bug.cgi?id=50464 |
+ |
+ Save 8 bytes in GraphicsContextState by rearranging the |
+ data members to reduce padding. |
+ |
+ * platform/graphics/GraphicsContextPrivate.h: |
+ (WebCore::GraphicsContextState::GraphicsContextState): |
+ |
+2010-12-03 Simon Fraser <simon.fraser@apple.com> |
+ |
+ Another Chromium build fix. |
+ |
+ * platform/graphics/skia/GraphicsContextSkia.cpp: |
+ (WebCore::GraphicsContext::setPlatformTextDrawingMode): |
+ |
+2010-12-03 Simon Fraser <simon.fraser@apple.com> |
+ |
+ Fix Chromium build. |
+ |
+ * platform/graphics/skia/PlatformContextSkia.h: |
+ |
+2010-12-03 Patrick Gansterer <paroga@webkit.org> |
+ |
+ Reviewed by Andreas Kling. |
+ |
+ [CMake] Remove WebCore_IDL_PURE_FILES |
+ https://bugs.webkit.org/show_bug.cgi?id=50445 |
+ |
+ * CMakeLists.txt: |
+ |
+2010-12-03 Jia Pu <jpu@apple.com> |
+ |
+ Reviewed by Darin Adler. |
+ |
+ Need to move all code that applies correction into correction panel callback. |
+ https://bugs.webkit.org/show_bug.cgi?id=50426 |
+ <rdar://problem/8720832> |
+ |
+ No new test, since there's no behavioral change. |
+ |
+ This patch is to prepare WebKit to work with upcoming AppKit changes. The main changes are: |
+ 1. Moved all calls to applyCorrectionPanelInfo() into handleCorrectionPanelResult(). |
+ 2. Added more user dictionary learning code. |
+ 3. Removed m_ prefix in all member variables of CorrectionPanelInfo. |
+ |
+ * editing/CorrectionPanelInfo.h: Remove m_ prefix on member variables. Added ReasonForDismissingCorrectionPanel enum type. |
+ |
+ * editing/Editor.cpp: Moved all calls to applyCorrectionPanelInfo() into handleCorrectionPanelResult(). |
+ Adopted new member variable naming in class CorrectionPanelInfo. |
+ (WebCore::Editor::respondToChangedSelection): |
+ (WebCore::Editor::~Editor): |
+ (WebCore::Editor::markMisspellingsAfterTypingToWord): |
+ (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): |
+ (WebCore::Editor::correctionPanelTimerFired): |
+ (WebCore::Editor::handleCorrectionPanelResult): |
+ (WebCore::Editor::startCorrectionPanelTimer): |
+ (WebCore::Editor::stopCorrectionPanelTimer): |
+ (WebCore::Editor::handleCancelOperation): |
+ (WebCore::Editor::dismissCorrectionPanel): |
+ (WebCore::Editor::applyCorrectionPanelInfo): |
+ |
+ * editing/Editor.h: Changed signature of dismissCorrectionPanel to use ReasonForDismissingCorrectionPanel. |
+ |
+ * loader/EmptyClients.h: Ditto. |
+ (WebCore::EmptyEditorClient::dismissCorrectionPanel): |
+ |
+ * page/EditorClient.h: Ditto. |
+ |
+2010-12-03 Pavel Feldman <pfeldman@chromium.org> |
+ |
+ Reviewed by Yury Semikhatsky. |
+ |
+ Web Inspector: reveal in elements panel does not switch the panel itself. |
+ https://bugs.webkit.org/show_bug.cgi?id=50408 |
+ |
+ * inspector/front-end/ElementsTreeOutline.js: |
+ (WebInspector.ElementsTreeOutline.prototype._contextMenuEventFired.focusElement): |
+ (WebInspector.ElementsTreeOutline.prototype._contextMenuEventFired): |
+ * inspector/front-end/ObjectPropertiesSection.js: |
+ (WebInspector.ObjectPropertyTreeElement.prototype._contextMenuEventFired): |
+ |
+2010-12-03 Simon Fraser <simon.fraser@apple.com> |
+ |
+ Reviewed by Nikolas Zimmermann. |
+ |
+ Clean up some text-related code on GraphicsContext |
+ https://bugs.webkit.org/show_bug.cgi?id=50464 |
+ |
+ Use defined types for textDrawingMode and it's associated flags. |
+ |
+ * html/canvas/CanvasRenderingContext2D.cpp: |
+ (WebCore::CanvasRenderingContext2D::drawTextInternal): |
+ * platform/graphics/GraphicsContext.cpp: |
+ (WebCore::GraphicsContext::textDrawingMode): |
+ (WebCore::GraphicsContext::setTextDrawingMode): |
+ (WebCore::GraphicsContext::setPlatformTextDrawingMode): |
+ * platform/graphics/GraphicsContext.h: |
+ * platform/graphics/GraphicsContextPrivate.h: |
+ (WebCore::GraphicsContextState::GraphicsContextState): |
+ * platform/graphics/cairo/FontCairo.cpp: |
+ (WebCore::drawGlyphsShadow): |
+ (WebCore::Font::drawGlyphs): |
+ * platform/graphics/cg/GraphicsContextCG.cpp: |
+ (WebCore::GraphicsContext::setPlatformTextDrawingMode): |
+ * platform/graphics/chromium/FontLinux.cpp: |
+ (WebCore::Font::drawGlyphs): |
+ (WebCore::Font::drawComplexText): |
+ * platform/graphics/gtk/FontGtk.cpp: |
+ (WebCore::drawGlyphsShadow): |
+ (WebCore::Font::drawComplexText): |
+ * platform/graphics/mac/FontMac.mm: |
+ (WebCore::Font::drawGlyphs): |
+ * platform/graphics/openvg/PainterOpenVG.cpp: |
+ (WebCore::PlatformPainterState::PlatformPainterState): |
+ (WebCore::PainterOpenVG::textDrawingMode): |
+ (WebCore::PainterOpenVG::setTextDrawingMode): |
+ (WebCore::PainterOpenVG::drawText): |
+ * platform/graphics/qt/FontQt.cpp: |
+ (WebCore::drawTextCommon): |
+ * platform/graphics/skia/PlatformContextSkia.cpp: |
+ (WebCore::PlatformContextSkia::State::State): |
+ (WebCore::PlatformContextSkia::getTextDrawingMode): |
+ (WebCore::PlatformContextSkia::setTextDrawingMode): |
+ * platform/graphics/skia/SkiaFontWin.cpp: |
+ (WebCore::windowsCanHandleTextDrawing): |
+ (WebCore::paintSkiaText): |
+ * platform/graphics/texmap/TextureMapper.h: |
+ (WebCore::TextureMapper::setTextDrawingMode): |
+ (WebCore::TextureMapper::textDrawingMode): |
+ (WebCore::TextureMapper::TextureMapper): |
+ * platform/graphics/win/FontCGWin.cpp: |
+ (WebCore::drawGDIGlyphs): |
+ (WebCore::Font::drawGlyphs): |
+ * platform/graphics/wince/GraphicsContextWinCE.cpp: |
+ (WebCore::GraphicsContext::drawText): |
+ * rendering/InlineTextBox.cpp: |
+ (WebCore::updateGraphicsContext): |
+ * rendering/RenderSVGResourceGradient.cpp: |
+ (WebCore::RenderSVGResourceGradient::applyResource): |
+ * rendering/RenderSVGResourcePattern.cpp: |
+ (WebCore::RenderSVGResourcePattern::applyResource): |
+ * rendering/RenderSVGResourceSolidColor.cpp: |
+ (WebCore::RenderSVGResourceSolidColor::applyResource): |
+ * svg/SVGFont.cpp: |
+ (WebCore::Font::drawTextUsingSVGFont): |
+ |
+2010-12-03 Chris Rogers <crogers@google.com> |
+ |
+ Reviewed by Kenneth Russell. |
+ |
+ First steps to adding web audio files to build systems |
+ https://bugs.webkit.org/show_bug.cgi?id=49952 |
+ |
+ No new tests since audio API is not yet implemented. |
+ |
+ * CMakeLists.txt: |
+ * DerivedSources.make: |
+ * ForwardingHeaders/wtf/Complex.h: Added. |
+ * GNUmakefile.am: |
+ * WebCore.gyp/WebCore.gyp: |
+ * WebCore.gypi: |
+ * WebCore.pri: |
+ * WebCore.pro: |
+ * bindings/js/JSDOMWindowCustom.cpp: |
+ (WebCore::JSDOMWindow::audioContext): |
+ * features.pri: |
+ * page/DOMWindow.idl: |
+ * platform/audio/HRTFElevation.cpp: |
+ |
+2010-12-03 Patrick Gansterer <paroga@webkit.org> |
+ |
+ Reviewed by David Levin. |
+ |
+ Use String::adopt in TextCodecWinCE::decode |
+ https://bugs.webkit.org/show_bug.cgi?id=50319 |
+ |
+ * platform/text/wince/TextCodecWinCE.cpp: |
+ (WebCore::TextCodecWinCE::decode): |
+ |
+2010-12-03 Brady Eidson <beidson@apple.com> |
+ |
+ Reviewed by Anders Carlsson. |
+ |
+ Groundwork for <rdar://problem/7660733> and https://bugs.webkit.org/show_bug.cgi?id=50191 |
+ WebKit2 Authentication Support |
+ |
+ * WebCore.exp.in: |
+ |
+ Expose the AuthenticationClient for WK2 platforms (Windows already does this): |
+ * platform/network/mac/AuthenticationChallenge.h: |
+ * platform/network/mac/AuthenticationMac.mm: |
+ (-[WebCoreAuthenticationClientAsChallengeSender client]): |
+ (WebCore::AuthenticationChallenge::authenticationClient): |
+ |
+ * platform/network/qt/AuthenticationChallenge.h: |
+ (WebCore::AuthenticationChallenge::authenticationClient): |
+ |
+2010-12-03 Ryosuke Niwa <rniwa@webkit.org> |
+ |
+ Reviewed by Darin Adler. |
+ |
+ REGRESSION: Crash when deleting text after textarea's value is modified on input event |
+ https://bugs.webkit.org/show_bug.cgi?id=49962 |
+ |
+ The crash was caused by TypingCommand::deleteKeyPressed's reusing a typing command for |
+ textarea's shadow DOM after its input event handler rewrote the value set by the typing command. |
+ Because the reused typing command's ending selection was pointing at a shadow node |
+ that has been detached from the document when the event handler set the new value, |
+ rootEditableElement of the ending selection was null and caused the crash. |
+ |
+ Fixed the bug by updating the ending selection of the last typing command when it differsfrom |
+ that of the current selection held by the SelectionController in TypingCommand::deleteKeyPressed. |
+ Also fixed similar bugs in forwardDeleteKeyPressed and insertText, and insertTextRunWithoutNewlines. |
+ |
+ Tests: editing/input/set-value-on-input-and-delete.html |
+ editing/input/set-value-on-input-and-forward-delete.html |
+ editing/input/set-value-on-input-and-type-input.html |
+ editing/input/set-value-on-input-and-type-textarea.html |
+ |
+ * editing/InsertTextCommand.h: Added TypingCommand as a friend because it needs to update selection. |
+ * editing/TypingCommand.cpp: |
+ (WebCore::TypingCommand::deleteKeyPressed): Updates the last typing command's selection as needed. |
+ (WebCore::TypingCommand::forwardDeleteKeyPressed): Ditto. |
+ (WebCore::TypingCommand::insertText): Ditto. |
+ (WebCore::TypingCommand::updateSelectionIfDifferentFromCurrentSelection): Added. |
+ (WebCore::TypingCommand::insertTextRunWithoutNewlines): Updates InsertTextCommand's selection as needed. |
+ * editing/TypingCommand.h: |
+ |
+2010-12-03 Daniel Cheng <dcheng@chromium.org> |
+ |
+ Reviewed by Tony Chang. |
+ |
+ Dragging and dropping into an empty document crashes WebKit. |
+ https://bugs.webkit.org/show_bug.cgi?id=48793 |
+ |
+ Remove the assert and update callers to check for a null return value. |
+ |
+ Test: manual-tests/drop-in-empty-doc.html |
+ |
+ * manual-tests/drop-in-empty-doc.html: Added. |
+ * manual-tests/resources/drop-in-empty-doc.xhtml: Added. |
+ * page/DragController.cpp: |
+ (WebCore::elementUnderMouse): |
+ (WebCore::DragController::tryDocumentDrag): |
+ (WebCore::DragController::concludeEditDrag): |
+ |
+2010-12-03 Patrick Gansterer <paroga@webkit.org> |
+ |
+ Reviewed by Andreas Kling. |
+ |
+ Move Inspector generator logic into main CMakeLists.txt file |
+ https://bugs.webkit.org/show_bug.cgi?id=50445 |
+ |
+ * CMakeLists.txt: |
+ |
+2010-12-03 Patrick Gansterer <paroga@webkit.org> |
+ |
+ Reviewed by Andreas Kling. |
+ |
+ Move StringWx.cpp into wtf directory |
+ https://bugs.webkit.org/show_bug.cgi?id=50060 |
+ |
+ * WebCore.gypi: |
+ * platform/text/wx/StringWx.cpp: Removed. |
+ |
+2010-12-03 Dimitri Glazkov <dglazkov@chromium.org> |
+ |
+ Reviewed by Darin Adler. |
+ |
REGRESSION(r72783): DOMActivate fires multiple times from input type=file |
https://bugs.webkit.org/show_bug.cgi?id=50396 |