Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Issue 5588011: Don't tweak buffer size for SPDY (Closed)

Created:
10 years ago by Mike Belshe
Modified:
9 years, 5 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Don't tweak buffer size for SPDY BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=68754

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -13 lines) Patch
M net/spdy/spdy_session.cc View 2 chunks +0 lines, -13 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Mike Belshe
10 years ago (2010-12-09 00:49:58 UTC) #1
willchan no longer on Chromium
10 years ago (2010-12-09 00:56:36 UTC) #2
LGTM

On Wed, Dec 8, 2010 at 4:49 PM, <mbelshe@chromium.org> wrote:

> Reviewers: willchan,
>
> Description:
> Don't tweak buffer size for SPDY
>
> BUG=none
> TEST=none
>
>
> Please review this at http://codereview.chromium.org/5588011/
>
> SVN Base: svn://chrome-svn/chrome/trunk/src/
>
> Affected files:
>  M     net/spdy/spdy_session.cc
>
>
> Index: net/spdy/spdy_session.cc
> ===================================================================
> --- net/spdy/spdy_session.cc    (revision 68605)
> +++ net/spdy/spdy_session.cc    (working copy)
> @@ -62,17 +62,6 @@
>
>  const int kReadBufferSize = 8 * 1024;
>
> -void AdjustSocketBufferSizes(ClientSocket* socket) {
> -  // Adjust socket buffer sizes.
> -  // SPDY uses one socket, and we want a really big buffer.
> -  // This greatly helps on links with packet loss - we can even
> -  // outperform Vista's dynamic window sizing algorithm.
> -  // TODO(mbelshe): more study.
> -  const int kSocketBufferSize = 512 * 1024;
> -  socket->SetReceiveBufferSize(kSocketBufferSize);
> -  socket->SetSendBufferSize(kSocketBufferSize);
> -}
> -
>  class NetLogSpdySessionParameter : public NetLog::EventParameters {
>  public:
>   NetLogSpdySessionParameter(const HostPortProxyPair& host_pair)
> @@ -294,8 +283,6 @@
>   static base::StatsCounter spdy_sessions("spdy.sessions");
>   spdy_sessions.Increment();
>
> -  AdjustSocketBufferSizes(connection->socket());
> -
>   state_ = CONNECTED;
>   connection_.reset(connection);
>   is_secure_ = is_secure;
>
>
>

Powered by Google App Engine
This is Rietveld 408576698