Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7079)

Unified Diff: chrome/browser/tab_contents/navigation_controller.cc

Issue 5581010: Merge 68646 - Makes instant run before unload listeners.... (Closed) Base URL: svn://svn.chromium.org/chrome/branches/597/src/
Patch Set: Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/tab_contents/navigation_controller.cc
===================================================================
--- chrome/browser/tab_contents/navigation_controller.cc (revision 68655)
+++ chrome/browser/tab_contents/navigation_controller.cc (working copy)
@@ -980,8 +980,10 @@
// Take over the session id from source.
session_id_ = source->session_id_;
- // Reset source's session id as we're taking it over.
- source->session_id_.clear();
+ // Reset source's session id as we're taking it over. We give it a new id in
+ // case source is added later on, which can happen with instant enabled if the
+ // tab has a before unload handler.
+ source->session_id_ = SessionID();
}
void NavigationController::PruneAllButActive() {
« no previous file with comments | « chrome/browser/tab_contents/navigation_controller.h ('k') | chrome/browser/tab_contents/navigation_controller_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698