Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Unified Diff: ceee/ie/broker/executors_manager.h

Issue 5581008: Add a new GetInstance() method for singleton classes, take 2. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ceee/ie/broker/executors_manager.h
diff --git a/ceee/ie/broker/executors_manager.h b/ceee/ie/broker/executors_manager.h
index 48a15f9d979a0d6e2584d703c02e58900008711f..48925d56973a3789761fa55bd01131adbc632681 100644
--- a/ceee/ie/broker/executors_manager.h
+++ b/ceee/ie/broker/executors_manager.h
@@ -34,6 +34,9 @@ class ExecutorsManager {
// Identifiers for destination threads where to run executors.
typedef DWORD ThreadId;
+ // Returns the singleton instance.
+ static ExecutorsManager* GetInstance();
+
// To avoid lint errors, even though we are only virtual for unittests.
virtual ~ExecutorsManager() {}
@@ -125,6 +128,7 @@ class ExecutorsManager {
// thread id.
virtual void CleanupMapsForThread(DWORD thread_id);
+ protected:
// Traits for Singleton<ExecutorsManager> so that we can pass an argument
// to the constructor.
struct SingletonTraits : public DefaultSingletonTraits<ExecutorsManager> {
@@ -136,7 +140,6 @@ class ExecutorsManager {
}
};
- protected:
// The data we pass to start our worker thread.
// THERE IS A COPY OF THIS CLASS IN THE UNITTEST WHICH YOU NEED TO UPDATE IF
// you change this one...

Powered by Google App Engine
This is Rietveld 408576698