Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Side by Side Diff: chrome_frame/utils.cc

Issue 5581008: Add a new GetInstance() method for singleton classes, take 2. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome_frame/utils.h" 5 #include "chrome_frame/utils.h"
6 6
7 #include <htiframe.h> 7 #include <htiframe.h>
8 #include <mshtml.h> 8 #include <mshtml.h>
9 #include <shlobj.h> 9 #include <shlobj.h>
10 10
(...skipping 705 matching lines...) Expand 10 before | Expand all | Expand 10 after
716 KEY_WRITE)) { 716 KEY_WRITE)) {
717 return config_key.DeleteValue(value_name); 717 return config_key.DeleteValue(value_name);
718 } 718 }
719 return false; 719 return false;
720 } 720 }
721 721
722 bool IsGcfDefaultRenderer() { 722 bool IsGcfDefaultRenderer() {
723 DWORD is_default = 0; // NOLINT 723 DWORD is_default = 0; // NOLINT
724 724
725 // First check policy settings 725 // First check policy settings
726 Singleton<PolicySettings> policy; 726 PolicySettings::RendererForUrl renderer =
727 PolicySettings::RendererForUrl renderer = policy->default_renderer(); 727 PolicySettings::GetInstance()->default_renderer();
728 if (renderer != PolicySettings::RENDERER_NOT_SPECIFIED) { 728 if (renderer != PolicySettings::RENDERER_NOT_SPECIFIED) {
729 is_default = (renderer == PolicySettings::RENDER_IN_CHROME_FRAME); 729 is_default = (renderer == PolicySettings::RENDER_IN_CHROME_FRAME);
730 } else { 730 } else {
731 // TODO(tommi): Implement caching for this config value as it gets 731 // TODO(tommi): Implement caching for this config value as it gets
732 // checked frequently. 732 // checked frequently.
733 RegKey config_key; 733 RegKey config_key;
734 if (config_key.Open(HKEY_CURRENT_USER, kChromeFrameConfigKey, KEY_READ)) { 734 if (config_key.Open(HKEY_CURRENT_USER, kChromeFrameConfigKey, KEY_READ)) {
735 config_key.ReadValueDW(kEnableGCFRendererByDefault, &is_default); 735 config_key.ReadValueDW(kEnableGCFRendererByDefault, &is_default);
736 } 736 }
737 } 737 }
738 738
739 return is_default != 0; 739 return is_default != 0;
740 } 740 }
741 741
742 RendererType RendererTypeForUrl(const std::wstring& url) { 742 RendererType RendererTypeForUrl(const std::wstring& url) {
743 // First check if the default renderer settings are specified by policy. 743 // First check if the default renderer settings are specified by policy.
744 // If so, then that overrides the user settings. 744 // If so, then that overrides the user settings.
745 Singleton<PolicySettings> policy; 745 PolicySettings::RendererForUrl renderer =
746 PolicySettings::RendererForUrl renderer = policy->GetRendererForUrl( 746 PolicySettings::GetInstance()->GetRendererForUrl(url.c_str());
747 url.c_str());
748 if (renderer != PolicySettings::RENDERER_NOT_SPECIFIED) { 747 if (renderer != PolicySettings::RENDERER_NOT_SPECIFIED) {
749 // We may know at this point that policy says do NOT render in Chrome Frame. 748 // We may know at this point that policy says do NOT render in Chrome Frame.
750 // To maintain consistency, we return RENDERER_TYPE_UNDETERMINED so that 749 // To maintain consistency, we return RENDERER_TYPE_UNDETERMINED so that
751 // content sniffing, etc. still take place. 750 // content sniffing, etc. still take place.
752 // TODO(tommi): Clarify the intent here. 751 // TODO(tommi): Clarify the intent here.
753 return (renderer == PolicySettings::RENDER_IN_CHROME_FRAME) ? 752 return (renderer == PolicySettings::RENDER_IN_CHROME_FRAME) ?
754 RENDERER_TYPE_CHROME_OPT_IN_URL : RENDERER_TYPE_UNDETERMINED; 753 RENDERER_TYPE_CHROME_OPT_IN_URL : RENDERER_TYPE_UNDETERMINED;
755 } 754 }
756 755
757 RegKey config_key; 756 RegKey config_key;
(...skipping 816 matching lines...) Expand 10 before | Expand all | Expand 10 after
1574 1573
1575 void EnumerateKeyValues(HKEY parent_key, const wchar_t* sub_key_name, 1574 void EnumerateKeyValues(HKEY parent_key, const wchar_t* sub_key_name,
1576 std::vector<std::wstring>* values) { 1575 std::vector<std::wstring>* values) {
1577 DCHECK(values); 1576 DCHECK(values);
1578 base::win::RegistryValueIterator url_list(parent_key, sub_key_name); 1577 base::win::RegistryValueIterator url_list(parent_key, sub_key_name);
1579 while (url_list.Valid()) { 1578 while (url_list.Valid()) {
1580 values->push_back(url_list.Value()); 1579 values->push_back(url_list.Value());
1581 ++url_list; 1580 ++url_list;
1582 } 1581 }
1583 } 1582 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698