Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(715)

Side by Side Diff: src/x64/debug-x64.cc

Issue 558069: Change StoreIC interface on x64 to pass receiver in rdx, not on stack. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: '' Created 10 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/x64/codegen-x64.cc ('k') | src/x64/full-codegen-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2009 the V8 project authors. All rights reserved. 1 // Copyright 2010 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
11 // with the distribution. 11 // with the distribution.
(...skipping 139 matching lines...) Expand 10 before | Expand all | Expand 10 after
151 void Debug::GenerateReturnDebugBreak(MacroAssembler* masm) { 151 void Debug::GenerateReturnDebugBreak(MacroAssembler* masm) {
152 // Register state just before return from JS function (from codegen-x64.cc). 152 // Register state just before return from JS function (from codegen-x64.cc).
153 // ----------- S t a t e ------------- 153 // ----------- S t a t e -------------
154 // -- rax: return value 154 // -- rax: return value
155 // ----------------------------------- 155 // -----------------------------------
156 Generate_DebugBreakCallHelper(masm, rax.bit(), true); 156 Generate_DebugBreakCallHelper(masm, rax.bit(), true);
157 } 157 }
158 158
159 159
160 void Debug::GenerateStoreICDebugBreak(MacroAssembler* masm) { 160 void Debug::GenerateStoreICDebugBreak(MacroAssembler* masm) {
161 // REgister state for IC store call (from ic-x64.cc). 161 // Register state for IC store call (from ic-x64.cc).
162 // ----------- S t a t e ------------- 162 // ----------- S t a t e -------------
163 // -- rax : value 163 // -- rax : value
164 // -- rcx : name 164 // -- rcx : name
165 // -- rdx : receiver
165 // ----------------------------------- 166 // -----------------------------------
166 Generate_DebugBreakCallHelper(masm, rax.bit() | rcx.bit(), false); 167 Generate_DebugBreakCallHelper(masm, rax.bit() | rcx.bit() | rdx.bit(), false);
167 } 168 }
168 169
169 170
170 void Debug::GenerateStubNoRegistersDebugBreak(MacroAssembler* masm) { 171 void Debug::GenerateStubNoRegistersDebugBreak(MacroAssembler* masm) {
171 // Register state for stub CallFunction (from CallFunctionStub in ic-x64.cc). 172 // Register state for stub CallFunction (from CallFunctionStub in ic-x64.cc).
172 // ----------- S t a t e ------------- 173 // ----------- S t a t e -------------
173 // No registers used on entry. 174 // No registers used on entry.
174 // ----------------------------------- 175 // -----------------------------------
175 Generate_DebugBreakCallHelper(masm, 0, false); 176 Generate_DebugBreakCallHelper(masm, 0, false);
176 } 177 }
(...skipping 16 matching lines...) Expand all
193 void BreakLocationIterator::SetDebugBreakAtReturn() { 194 void BreakLocationIterator::SetDebugBreakAtReturn() {
194 ASSERT(Assembler::kJSReturnSequenceLength >= 195 ASSERT(Assembler::kJSReturnSequenceLength >=
195 Assembler::kCallInstructionLength); 196 Assembler::kCallInstructionLength);
196 rinfo()->PatchCodeWithCall(Debug::debug_break_return()->entry(), 197 rinfo()->PatchCodeWithCall(Debug::debug_break_return()->entry(),
197 Assembler::kJSReturnSequenceLength - Assembler::kCallInstructionLength); 198 Assembler::kJSReturnSequenceLength - Assembler::kCallInstructionLength);
198 } 199 }
199 200
200 #endif // ENABLE_DEBUGGER_SUPPORT 201 #endif // ENABLE_DEBUGGER_SUPPORT
201 202
202 } } // namespace v8::internal 203 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/x64/codegen-x64.cc ('k') | src/x64/full-codegen-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698