Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(629)

Issue 558069: Change StoreIC interface on x64 to pass receiver in rdx, not on stack. (Closed)

Created:
10 years, 10 months ago by William Hesse
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Change StoreIC interface on x64 to pass receiver in rdx, not on stack. Committed: http://code.google.com/p/v8/source/detail?r=3765

Patch Set 1 #

Total comments: 4

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -63 lines) Patch
M src/ia32/debug-ia32.cc View 1 2 2 chunks +4 lines, -3 lines 0 comments Download
M src/x64/codegen-x64.cc View 1 2 2 chunks +1 line, -3 lines 0 comments Download
M src/x64/debug-x64.cc View 1 2 2 chunks +4 lines, -3 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 1 2 6 chunks +15 lines, -10 lines 0 comments Download
M src/x64/ic-x64.cc View 1 2 4 chunks +6 lines, -7 lines 0 comments Download
M src/x64/stub-cache-x64.cc View 1 2 7 chunks +15 lines, -25 lines 0 comments Download
M src/x64/virtual-frame-x64.cc View 1 2 2 chunks +26 lines, -12 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
William Hesse
A review for you. Straightforward copy of IA32 version of change.
10 years, 10 months ago (2010-02-01 14:55:51 UTC) #1
Kevin Millikin (Chromium)
Just a drive-by. http://codereview.chromium.org/558069/diff/1/2 File src/ia32/debug-ia32.cc (right): http://codereview.chromium.org/558069/diff/1/2#newcode140 src/ia32/debug-ia32.cc:140: Generate_DebugBreakCallHelper(masm, eax.bit() | ecx.bit() | edx.bit(), ...
10 years, 10 months ago (2010-02-01 15:35:36 UTC) #2
William Hesse
http://codereview.chromium.org/558069/diff/1/2 File src/ia32/debug-ia32.cc (right): http://codereview.chromium.org/558069/diff/1/2#newcode140 src/ia32/debug-ia32.cc:140: Generate_DebugBreakCallHelper(masm, eax.bit() | ecx.bit() | edx.bit(), false); On 2010/02/01 ...
10 years, 10 months ago (2010-02-01 15:55:58 UTC) #3
fschneider
10 years, 10 months ago (2010-02-01 16:32:44 UTC) #4
LGTM.

Powered by Google App Engine
This is Rietveld 408576698