Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Side by Side Diff: src/ic.cc

Issue 558067: Remove StoreIC::Generate, and inline StoreIC::GenerateInitialize. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 10 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ic.h ('k') | src/x64/ic-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2006-2009 the V8 project authors. All rights reserved. 1 // Copyright 2006-2009 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1377 matching lines...) Expand 10 before | Expand all | Expand 10 after
1388 1388
1389 // Set the new property value and do the map transition. 1389 // Set the new property value and do the map transition.
1390 object->set_properties(new_storage); 1390 object->set_properties(new_storage);
1391 object->set_map(transition); 1391 object->set_map(transition);
1392 1392
1393 // Return the stored value. 1393 // Return the stored value.
1394 return value; 1394 return value;
1395 } 1395 }
1396 1396
1397 1397
1398 void StoreIC::GenerateInitialize(MacroAssembler* masm) {
1399 Generate(masm, ExternalReference(IC_Utility(kStoreIC_Miss)));
1400 }
1401
1402
1403 void StoreIC::GenerateMiss(MacroAssembler* masm) {
1404 Generate(masm, ExternalReference(IC_Utility(kStoreIC_Miss)));
1405 }
1406
1407
1408 // Used from ic_<arch>.cc. 1398 // Used from ic_<arch>.cc.
1409 Object* KeyedStoreIC_Miss(Arguments args) { 1399 Object* KeyedStoreIC_Miss(Arguments args) {
1410 NoHandleAllocation na; 1400 NoHandleAllocation na;
1411 ASSERT(args.length() == 3); 1401 ASSERT(args.length() == 3);
1412 KeyedStoreIC ic; 1402 KeyedStoreIC ic;
1413 IC::State state = IC::StateFrom(ic.target(), args[0]); 1403 IC::State state = IC::StateFrom(ic.target(), args[0]);
1414 return ic.Store(state, args.at<Object>(0), args.at<Object>(1), 1404 return ic.Store(state, args.at<Object>(0), args.at<Object>(1),
1415 args.at<Object>(2)); 1405 args.at<Object>(2));
1416 } 1406 }
1417 1407
(...skipping 15 matching lines...) Expand all
1433 #undef ADDR 1423 #undef ADDR
1434 }; 1424 };
1435 1425
1436 1426
1437 Address IC::AddressFromUtilityId(IC::UtilityId id) { 1427 Address IC::AddressFromUtilityId(IC::UtilityId id) {
1438 return IC_utilities[id]; 1428 return IC_utilities[id];
1439 } 1429 }
1440 1430
1441 1431
1442 } } // namespace v8::internal 1432 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/ic.h ('k') | src/x64/ic-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698