Issue 558042: Add fast code generator visitor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 558042: Add fast code generator visitor. (Closed)

Created:
10 years, 10 months ago by Kevin Millikin (Chromium)

Modified:
9 years, 7 months ago

Reviewers:
fschneider

CC:
v8-dev

Visibility:
Public.

Description

Add fast code generator visitor. It does not yet emit code so there is a flag --print-ir to print the AST as seen by the code generator. Committed: http://code.google.com/p/v8/source/detail?r=3748

Patch Set 1 #

Total comments: 1

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+278 lines, -8 lines)			Patch
M	src/compiler.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/compiler.cc	View	3 chunks	+4 lines, -7 lines	0 comments	Download
M	src/fast-codegen.h	View	1 chunk	+34 lines, -0 lines	0 comments	Download
M	src/fast-codegen.cc	View	3 chunks	+238 lines, -0 lines	1 comment	Download
M	src/flag-definitions.h	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

fschneider

10 years, 10 months ago (2010-01-29 13:02:29 UTC) #2

http://codereview.chromium.org/558042/diff/1/4
File src/fast-codegen.cc (right):

http://codereview.chromium.org/558042/diff/1/4#newcode346
src/fast-codegen.cc:346: info_ = NULL;
Maybe I miss something here. Why do we need to reset those member to NULL?

Expand Messages | Collapse Messages