DevTools: fix console autocomplete against global object (while not on a brea...

webkit/glue/devtools/js/devtools.js

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview Tools is a main class that wires all components of the
  * DevTools frontend together. It is also responsible for overriding existing
  * WebInspector functionality while it is getting upstreamed into WebCore.
  */
 goog.provide('devtools.Tools');
@@ skipping 402 matching lines @@
   }
   orig.call(this, args);
 };
 })();
 
 
 (function() {
 var orig = InjectedScriptAccess.prototype.getCompletions;
 InjectedScriptAccess.prototype.getCompletions = function(expressionString,
     includeInspectorCommandLineAPI, callFrameId, reportCompletions) {
-  if (goog.isDef(callFrameId)) {
+  if (typeof callFrameId === "number") {

[yurys, 2010/01/28 21:20:25]

Could you explain why the old code didn't work?

     devtools.tools.getDebuggerAgent().resolveCompletionsOnFrame(
         expressionString, callFrameId, reportCompletions);
   } else {
     return orig.apply(this, arguments);
   }
 };
 })();
 
 
 (function() {
@@ skipping 30 matching lines @@
     return;
   }
   originalAddToFrame.call(this, identifier, resource.mimeType, element);
 };
 })();
 
 WebInspector.pausedScript = function(callFrames)
 {
     this.panels.scripts.debuggerPaused(callFrames);
 };