Issue 558016: Strengthen a few assertions and add zapping of allocated...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 558016: Strengthen a few assertions and add zapping of allocated... (Closed)

Created:
10 years, 11 months ago by Kasper Lund

Modified:
9 years, 7 months ago

Reviewers:
Kevin Millikin (Chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Strengthen a few assertions and add zapping of allocated memory blocks filling them out with recognizable non-zero bit pattern in debug mode. Committed: http://code.google.com/p/v8/source/detail?r=3729

Patch Set 1 #

Total comments: 1

Created: 10 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+36 lines, -9 lines)			Patch
M	src/heap-inl.h	View	1 chunk	+5 lines, -1 line	0 comments	Download
M	src/objects.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/objects-inl.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/spaces.h	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	src/spaces.cc	View	6 chunks	+24 lines, -6 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Kevin Millikin (Chromium)

10 years, 11 months ago (2010-01-28 08:38:02 UTC) #2

LGTM.

http://codereview.chromium.org/558016/diff/1/5
File src/spaces.cc (right):

http://codereview.chromium.org/558016/diff/1/5#newcode361
src/spaces.cc:361: // Is this the problematic one?
I'm not sure this comment adds anything.

Expand Messages | Collapse Messages