Issue 558008: Use the USE_NSS macro to help porting to FreeBSD, OpenBSD, etc....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 558008: Use the USE_NSS macro to help porting to FreeBSD, OpenBSD, etc.... (Closed)

Created:
10 years, 10 months ago by wtc

Modified:
9 years, 7 months ago

Reviewers:
Evan Martin, Peter Valchev

CC:
chromium-reviews, brettw+cc_chromium.org, darin (slow to review)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Use the USE_NSS macro to help porting to FreeBSD, OpenBSD, etc. Fix cpplint nits. R=evan,pvalchev BUG=none TEST=No compilation errors. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=37358

Patch Set 1 #

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+16 lines, -15 lines)			Patch
M	base/test/test_suite.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	build/build_config.h	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	net/http/des.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	net/socket/ssl_test_util.cc	View	6 chunks	+8 lines, -8 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

wtc

10 years, 10 months ago (2010-01-28 00:02:20 UTC) #4

On 2010/01/27 23:40:13, Evan Martin wrote:
>
> (why are you doing this?)

Because I love the BSDs!

OK, it's part of my work on porting SSLClientSocketNSS to Windows
(http://crbug.com/28744).  I need to make sure EnsureNSPRInit
and EnsureNSSInit are called on the right platforms.

Expand Messages | Collapse Messages