Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 5578008: Add font-equivalent mapping for a few Chinese/Japanese fonts for CrOS.... (Closed)

Created:
10 years ago by jungshik at Google
Modified:
9 years, 7 months ago
Reviewers:
Evan Martin
CC:
chromium-reviews
Visibility:
Public.

Description

Add font-equivalent mapping for a few Chinese/Japanese fonts for CrOS. The following aliases are added to be recognized in addition to what we have. The first four are applicable to Chrome on Linux and ChromeOS. The last two are for Chrome OS. IPAPMincho -> MS P Mincho IPAMincho -> MS Mincho IPAPGothic -> MS P Gothic IPAGothic -> MS Gothic Song ASC -> Simsun N Song ASC -> NSimsun BUG=65382, chromium-os:10182, chromium-os:8757 TEST=Install IPA fonts on Linux and make sure that Windows Japanese fonts are not installed on your machine. Also, add what's added in http://codereview.chromium.org/5695005/ to your copy of /etc/fonts/local.conf. And, load cjfontalias.html attached to http://crosbug.com/10182 to make sure that all three columns look identical (each rows should be different). Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71295

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 3

Patch Set 4 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -23 lines) Patch
M skia/ext/SkFontHost_fontconfig_direct.cpp View 1 2 3 3 chunks +74 lines, -23 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
jungshik at Google
10 years ago (2010-12-11 01:07:33 UTC) #1
jungshik at Google
http://codereview.chromium.org/5578008/diff/6001/skia/ext/SkFontHost_fontconfig_direct.cpp File skia/ext/SkFontHost_fontconfig_direct.cpp (right): http://codereview.chromium.org/5578008/diff/6001/skia/ext/SkFontHost_fontconfig_direct.cpp#newcode113 skia/ext/SkFontHost_fontconfig_direct.cpp:113: for (size_t i = 0; i < kFontCount; ++i) ...
10 years ago (2010-12-11 01:10:50 UTC) #2
jungshik at Google
Evan, can you take a look?
10 years ago (2010-12-14 17:49:40 UTC) #3
Evan Martin
http://codereview.chromium.org/5578008/diff/6001/skia/ext/SkFontHost_fontconfig_direct.cpp File skia/ext/SkFontHost_fontconfig_direct.cpp (right): http://codereview.chromium.org/5578008/diff/6001/skia/ext/SkFontHost_fontconfig_direct.cpp#newcode86 skia/ext/SkFontHost_fontconfig_direct.cpp:86: { PMINCHO, "MS P明朝" }, I worry that people's ...
10 years ago (2010-12-14 18:04:20 UTC) #4
jungshik at Google
Oops. I thought I asked you to take another look after updating the CL, but ...
10 years ago (2010-12-23 02:01:26 UTC) #5
Evan Martin
LGTM, I guess we should just profile a page before making performance optimizations
10 years ago (2010-12-23 21:28:29 UTC) #6
jungshik at Google
9 years, 11 months ago (2011-01-13 18:21:39 UTC) #7
Thank you for the review. I wanted to land this when few people are around, but
kept forgetting. Anyway, it's landed last night at r=71295 and all the page
cycler tests (on Linux and Linux LowMem) didn't slow down (the numbers fluctuate
about the same value before and after the CL landing).

Powered by Google App Engine
This is Rietveld 408576698