Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Unified Diff: chrome/common/pref_store.h

Issue 5574006: Start deinlining non-empty virtual methods. (This will be automatically checked (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Remove virtual from VideoFrame::type() Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/net/gaia/gaia_authenticator.cc ('k') | chrome/common/pref_store.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/pref_store.h
diff --git a/chrome/common/pref_store.h b/chrome/common/pref_store.h
index 808ffbd20d986e369b63148ee03c21bd1f5af304..2bac004e3835691c78db1ae04bc3b47924df9892 100644
--- a/chrome/common/pref_store.h
+++ b/chrome/common/pref_store.h
@@ -70,12 +70,12 @@ class PrefStore {
virtual void RemoveObserver(ObserverInterface* observer) {}
// Whether the store has completed all asynchronous initialization.
- virtual bool IsInitializationComplete() { return true; }
+ virtual bool IsInitializationComplete();
// Whether the store is in a pseudo-read-only mode where changes are not
// actually persisted to disk. This happens in some cases when there are
// read errors during startup.
- virtual bool ReadOnly() const { return true; }
+ virtual bool ReadOnly() const;
// TODO(danno): PrefValueStore shouldn't allow direct access to the
// DictionaryValue. Instead, it should have getters that return a
@@ -85,7 +85,7 @@ class PrefStore {
virtual PrefReadError ReadPrefs() = 0;
- virtual bool WritePrefs() { return true; }
+ virtual bool WritePrefs();
virtual void ScheduleWritePrefs() { }
« no previous file with comments | « chrome/common/net/gaia/gaia_authenticator.cc ('k') | chrome/common/pref_store.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698