app/menus/menu_model.h - Issue 5574006: Start deinlining non-empty virtual methods. (This will be automatically checked

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: app/menus/menu_model.h

Issue 5574006: Start deinlining non-empty virtual methods. (This will be automatically checked (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Remove virtual from VideoFrame::type() Created 10 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: app/menus/menu_model.h

diff --git a/app/menus/menu_model.h b/app/menus/menu_model.h

index 8247f60af0c461d6b551957d766b1efe663d430b..62732cd2be5f78bc1a0fe9a6bbcd455ae35438cf 100644

--- a/app/menus/menu_model.h

+++ b/app/menus/menu_model.h

@@ -49,7 +49,7 @@ class MenuModel {

// IMPORTANT: If the model implementation returns something _other_ than 0

// here, it must offset the values for |index| it passes to the

// methods below by this number - this is NOT done automatically!

- virtual int GetFirstItemIndex(gfx::NativeMenu native_menu) const { return 0; }

+ virtual int GetFirstItemIndex(gfx::NativeMenu native_menu) const;

// Returns the number of items in the menu.

virtual int GetItemCount() const = 0;

@@ -70,7 +70,7 @@ class MenuModel {

// Returns the font use for the label at the specified index.

// If NULL, then use default font.

- virtual const gfx::Font* GetLabelFontAt(int index) const { return NULL; }

+ virtual const gfx::Font* GetLabelFontAt(int index) const;

// Gets the acclerator information for the specified index, returning true if

// there is a shortcut accelerator for the item, false otherwise.

« no previous file with comments | « app/animation.cc ('k') | app/menus/menu_model.cc » ('j') | no next file with comments »