media/base/video_frame.h - Issue 5574006: Start deinlining non-empty virtual methods. (This will be automatically checked

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/base/video_frame.h

Issue 5574006: Start deinlining non-empty virtual methods. (This will be automatically checked (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 10 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: media/base/video_frame.h

diff --git a/media/base/video_frame.h b/media/base/video_frame.h

index ecb3f8a9e3bf5a44607252a4f2646996f245150d..5a9ff768221d8f9c65b9711a148fefffeafd237f 100644

--- a/media/base/video_frame.h

+++ b/media/base/video_frame.h

@@ -94,7 +94,7 @@ class VideoFrame : public StreamSample {

static void CreateBlackFrame(int width, int height,

scoped_refptr<VideoFrame>* frame_out);

- virtual SurfaceType type() const { return type_; }

+ virtual SurfaceType type() const;

scherkus (not reviewing) 2010/12/09 02:24:15 just checked... this method shouldn't be virtual

Format format() const { return format_; }

« no previous file with comments | « media/base/filters.cc ('k') | media/base/video_frame.cc » ('j') | no next file with comments »