Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Side by Side Diff: net/http/http_auth_handler.h

Issue 5574006: Start deinlining non-empty virtual methods. (This will be automatically checked (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Remove virtual from VideoFrame::type() Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « net/ftp/ftp_directory_listing_parser_windows.cc ('k') | net/http/http_auth_handler.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef NET_HTTP_HTTP_AUTH_HANDLER_H_ 5 #ifndef NET_HTTP_HTTP_AUTH_HANDLER_H_
6 #define NET_HTTP_HTTP_AUTH_HANDLER_H_ 6 #define NET_HTTP_HTTP_AUTH_HANDLER_H_
7 #pragma once 7 #pragma once
8 8
9 #include <string> 9 #include <string>
10 10
(...skipping 105 matching lines...) Expand 10 before | Expand all | Expand 10 after
116 // preemptive authentication, and must use the same handler object 116 // preemptive authentication, and must use the same handler object
117 // throughout the life of an HTTP transaction. 117 // throughout the life of an HTTP transaction.
118 bool is_connection_based() const { 118 bool is_connection_based() const {
119 return (properties_ & IS_CONNECTION_BASED) != 0; 119 return (properties_ & IS_CONNECTION_BASED) != 0;
120 } 120 }
121 121
122 // Returns true if the response to the current authentication challenge 122 // Returns true if the response to the current authentication challenge
123 // requires an identity. 123 // requires an identity.
124 // TODO(wtc): Find a better way to handle a multi-round challenge-response 124 // TODO(wtc): Find a better way to handle a multi-round challenge-response
125 // sequence used by a connection-based authentication scheme. 125 // sequence used by a connection-based authentication scheme.
126 virtual bool NeedsIdentity() { return true; } 126 virtual bool NeedsIdentity();
127 127
128 // Returns whether the default credentials may be used for the |origin| passed 128 // Returns whether the default credentials may be used for the |origin| passed
129 // into |InitFromChallenge|. If true, the user does not need to be prompted 129 // into |InitFromChallenge|. If true, the user does not need to be prompted
130 // for username and password to establish credentials. 130 // for username and password to establish credentials.
131 // NOTE: SSO is a potential security risk. 131 // NOTE: SSO is a potential security risk.
132 // TODO(cbentzel): Add a pointer to Firefox documentation about risk. 132 // TODO(cbentzel): Add a pointer to Firefox documentation about risk.
133 virtual bool AllowsDefaultCredentials() { return false; } 133 virtual bool AllowsDefaultCredentials();
134 134
135 protected: 135 protected:
136 enum Property { 136 enum Property {
137 ENCRYPTS_IDENTITY = 1 << 0, 137 ENCRYPTS_IDENTITY = 1 << 0,
138 IS_CONNECTION_BASED = 1 << 1, 138 IS_CONNECTION_BASED = 1 << 1,
139 }; 139 };
140 140
141 // Initializes the handler using a challenge issued by a server. 141 // Initializes the handler using a challenge issued by a server.
142 // |challenge| must be non-NULL and have already tokenized the 142 // |challenge| must be non-NULL and have already tokenized the
143 // authentication scheme, but none of the tokens occuring after the 143 // authentication scheme, but none of the tokens occuring after the
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
188 CompletionCallback* original_callback_; 188 CompletionCallback* original_callback_;
189 CompletionCallbackImpl<HttpAuthHandler> wrapper_callback_; 189 CompletionCallbackImpl<HttpAuthHandler> wrapper_callback_;
190 // When GenerateAuthToken was called. 190 // When GenerateAuthToken was called.
191 base::TimeTicks generate_auth_token_start_; 191 base::TimeTicks generate_auth_token_start_;
192 scoped_refptr<base::Histogram> histogram_; 192 scoped_refptr<base::Histogram> histogram_;
193 }; 193 };
194 194
195 } // namespace net 195 } // namespace net
196 196
197 #endif // NET_HTTP_HTTP_AUTH_HANDLER_H_ 197 #endif // NET_HTTP_HTTP_AUTH_HANDLER_H_
OLDNEW
« no previous file with comments | « net/ftp/ftp_directory_listing_parser_windows.cc ('k') | net/http/http_auth_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698