Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(902)

Side by Side Diff: net/ftp/ftp_directory_listing_parser_ls.h

Issue 5574006: Start deinlining non-empty virtual methods. (This will be automatically checked (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Remove virtual from VideoFrame::type() Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « net/base/host_resolver.cc ('k') | net/ftp/ftp_directory_listing_parser_ls.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef NET_FTP_FTP_DIRECTORY_LISTING_PARSER_LS_H_ 5 #ifndef NET_FTP_FTP_DIRECTORY_LISTING_PARSER_LS_H_
6 #define NET_FTP_FTP_DIRECTORY_LISTING_PARSER_LS_H_ 6 #define NET_FTP_FTP_DIRECTORY_LISTING_PARSER_LS_H_
7 #pragma once 7 #pragma once
8 8
9 #include <queue> 9 #include <queue>
10 10
11 #include "base/time.h" 11 #include "base/time.h"
12 #include "net/ftp/ftp_directory_listing_parser.h" 12 #include "net/ftp/ftp_directory_listing_parser.h"
13 13
14 namespace net { 14 namespace net {
15 15
16 // Parser for "ls -l"-style directory listing. 16 // Parser for "ls -l"-style directory listing.
17 class FtpDirectoryListingParserLs : public FtpDirectoryListingParser { 17 class FtpDirectoryListingParserLs : public FtpDirectoryListingParser {
18 public: 18 public:
19 // Constructor. When the current time is needed to guess the year on partial 19 // Constructor. When the current time is needed to guess the year on partial
20 // date strings, |current_time| will be used. This allows passing a specific 20 // date strings, |current_time| will be used. This allows passing a specific
21 // date during testing. 21 // date during testing.
22 explicit FtpDirectoryListingParserLs(const base::Time& current_time); 22 explicit FtpDirectoryListingParserLs(const base::Time& current_time);
23 virtual ~FtpDirectoryListingParserLs(); 23 virtual ~FtpDirectoryListingParserLs();
24 24
25 // FtpDirectoryListingParser methods: 25 // FtpDirectoryListingParser methods:
26 virtual FtpServerType GetServerType() const { return SERVER_LS; } 26 virtual FtpServerType GetServerType() const;
27 virtual bool ConsumeLine(const string16& line); 27 virtual bool ConsumeLine(const string16& line);
28 virtual bool OnEndOfInput(); 28 virtual bool OnEndOfInput();
29 virtual bool EntryAvailable() const; 29 virtual bool EntryAvailable() const;
30 virtual FtpDirectoryListingEntry PopEntry(); 30 virtual FtpDirectoryListingEntry PopEntry();
31 31
32 private: 32 private:
33 bool received_nonempty_line_; 33 bool received_nonempty_line_;
34 34
35 // True after we have received a "total n" listing header, where n is an 35 // True after we have received a "total n" listing header, where n is an
36 // integer. Only one such header is allowed per listing. 36 // integer. Only one such header is allowed per listing.
37 bool received_total_line_; 37 bool received_total_line_;
38 38
39 // Store the current time. We need it to correctly parse received dates. 39 // Store the current time. We need it to correctly parse received dates.
40 const base::Time current_time_; 40 const base::Time current_time_;
41 41
42 std::queue<FtpDirectoryListingEntry> entries_; 42 std::queue<FtpDirectoryListingEntry> entries_;
43 43
44 DISALLOW_COPY_AND_ASSIGN(FtpDirectoryListingParserLs); 44 DISALLOW_COPY_AND_ASSIGN(FtpDirectoryListingParserLs);
45 }; 45 };
46 46
47 } // namespace net 47 } // namespace net
48 48
49 #endif // NET_FTP_FTP_DIRECTORY_LISTING_PARSER_LS_H_ 49 #endif // NET_FTP_FTP_DIRECTORY_LISTING_PARSER_LS_H_
OLDNEW
« no previous file with comments | « net/base/host_resolver.cc ('k') | net/ftp/ftp_directory_listing_parser_ls.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698