Print preview: Display a message when the PDF viewer is missing....

chrome/browser/resources/print_preview.js

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 var localStrings = new LocalStrings();
+var hasPDFPlugin = true;
 
 /**
  * Window onload handler, sets up the page.
  */
 function load() {
   $('cancel-button').addEventListener('click', function(e) {
     window.close();
   });
 
   chrome.send('getPrinters');
@@ skipping 20 matching lines @@
 }
 
 function onPDFLoad() {
   $('pdf-viewer').fitToHeight();
 }
 
 /**
  * Create the PDF plugin or reload the existing one.
  */
 function createPDFPlugin(url) {
+  if (!hasPDFPlugin) {
+    return;
+  }
+
   if ($('pdf-viewer')) {
-    pdfPlugin.reload();
+    $('pdf-viewer').reload();

[Lei Zhang, 2010/12/06 08:31:55]

Typo in previous CL.

     return;
   }
 
   var loadingElement = $('loading');
+  loadingElement.classList.add('hidden');
   var mainView = loadingElement.parentNode;
-  mainView.removeChild(loadingElement);
 
-  pdfPlugin = document.createElement('object');
+  var pdfPlugin = document.createElement('object');

[Lei Zhang, 2010/12/06 08:31:55]

Typo in previous CL.

   pdfPlugin.setAttribute('id', 'pdf-viewer');
   pdfPlugin.setAttribute('type', 'application/pdf');
   pdfPlugin.setAttribute('src', url);
   mainView.appendChild(pdfPlugin);
+  if (typeof pdfPlugin.onload != 'function') {

[Lei Zhang, 2010/12/06 08:31:55]

This check does not work until we add the plugin to the DOM.

[James Hawkins, 2010/12/06 18:23:36]

You should just be able to check if (pdfPlugin.onload), assuming the problem is
the onload method doesn't exist yet.

[Lei Zhang, 2010/12/06 20:47:14]

Done, but this still needs to happen after the plugin has been added to the DOM.

+    hasPDFPlugin = false;
+    mainView.removeChild(pdfPlugin);
+    $('no-plugin').classList.remove('hidden');

[James Hawkins, 2010/12/06 18:23:36]

You don't ever set 'hidden' for 'no-plugin', so there's nothing to remove.

[Lei Zhang, 2010/12/06 20:47:14]

Whoops, added class="hidden" in the html file.

+    return;
+  }
   pdfPlugin.onload('onPDFLoad()');
 }
 
 window.addEventListener('DOMContentLoaded', load);