Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 5573007: Add some desired options to the au test harness. (Closed)

Created:
10 years ago by sosa
Modified:
9 years, 6 months ago
Reviewers:
dgarrett
CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa
Visibility:
Public.

Description

Add some desired options to the au test harness. Adds verbose flag to print output while updates are running rather than on error. Adds test_prefix to specify a prefix of tests you want to run Flushes stderr more reliably for builders and debugging purposes Dies when stateful_updates fail Change-Id: I9e4289deec3688c52b92763eee9334a8868f948e BUG=chromium-os:6910 TEST=Ran with test_prefix and verbose on and off Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=53ac954

Patch Set 1 #

Patch Set 2 : ws #

Total comments: 3

Patch Set 3 : Better parameters #

Patch Set 4 : Change exceptions #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -79 lines) Patch
M bin/cros_au_test_harness.py View 1 2 3 11 chunks +104 lines, -78 lines 0 comments Download
M image_to_live.sh View 1 chunk +1 line, -1 line 0 comments Download
M lib/cros_build_lib.py View 3 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
sosa
http://codereview.chromium.org/5573007/diff/2001/bin/cros_au_test_harness.py File bin/cros_au_test_harness.py (right): http://codereview.chromium.org/5573007/diff/2001/bin/cros_au_test_harness.py#newcode429 bin/cros_au_test_harness.py:429: parser.add_option('--no_graphics', action='store_true', I just sorted this by long name ...
10 years ago (2010-12-03 22:33:28 UTC) #1
dgarrett
http://codereview.chromium.org/5573007/diff/2001/bin/cros_au_test_harness.py File bin/cros_au_test_harness.py (right): http://codereview.chromium.org/5573007/diff/2001/bin/cros_au_test_harness.py#newcode454 bin/cros_au_test_harness.py:454: if options.verbose: run_command = RunCommand This isn't quite what ...
10 years ago (2010-12-06 18:35:23 UTC) #2
sosa
PTAL. I tested this change :)
10 years ago (2010-12-07 01:25:00 UTC) #3
dgarrett
If passed, but only because you found a bug I introduced moving code around. In ...
10 years ago (2010-12-07 01:41:10 UTC) #4
sosa
PTAL re-tested. Changed to generate UpdateExceptions when RunCommand fails under verbose. Also fixed indention bug
10 years ago (2010-12-07 22:33:05 UTC) #5
dgarrett
10 years ago (2010-12-08 19:36:05 UTC) #6
It still feels weird to me to have some tests fail if you set --verbose, but I
understand why.

Otherwise LGTM, and thanks for fixing my indention problem!

On 2010/12/07 22:33:05, sosa wrote:
> PTAL re-tested.
> 
> Changed to generate UpdateExceptions when RunCommand fails under verbose.
> 
> Also fixed indention bug

Powered by Google App Engine
This is Rietveld 408576698