Issue 5573002: Enable -integrated-as for Clang builds on Linux.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5573002: Enable -integrated-as for Clang builds on Linux. (Closed)

Created:
10 years ago by hans

Modified:
9 years, 5 months ago

Reviewers:
Nico

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Enable -integrated-as for Clang builds on Linux. Clang needs to be r120563 or later. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=68009

Patch Set 1 #

Created: 10 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -3 lines)			Patch
	M	build/common.gypi	View		1 chunk	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Nico

10 years ago (2010-12-02 15:22:16 UTC) #2

Lg
On Dec 2, 2010 2:27 AM, <hans@chromium.org> wrote:
> Reviewers: Nico,
>
> Description:
> Enable -integrated-as for Clang builds on Linux.
>
> Clang needs to be r120563 or later.
>
> BUG=none
> TEST=none
>
> Please review this at http://codereview.chromium.org/5573002/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files:
> M build/common.gypi
>
>
> Index: build/common.gypi
> diff --git a/build/common.gypi b/build/common.gypi
> index
>
1b260cde49fd3f135f2d60f39e8b8a1ed103d3f1..f07ec08a366bf1c9ca8ce6d643d80188ca553be7

> 100644
> --- a/build/common.gypi
> +++ b/build/common.gypi
> @@ -1168,9 +1168,6 @@
> # http://code.google.com/p/googletest/source/detail?r=446 .
> # TODO(thakis): Use -isystem instead (http://crbug.com/58751
> ).
> '-Wno-unnamed-type-template-args',
> - # The integrated assembler chokes on one ffmpeg file.
> - # http://crbug.com/61931
> - '-no-integrated-as',
> ],
> 'cflags!': [
> # Clang doesn't seem to know know this flag.
>
>

Expand Messages | Collapse Messages