Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5335)

Unified Diff: chrome/test/webdriver/commands/command.h

Issue 5572001: Send screenshots back to the client for debugging (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: changed PageSnapshotTaker to use JSON interface Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/webdriver/commands/command.h
diff --git a/chrome/test/webdriver/commands/command.h b/chrome/test/webdriver/commands/command.h
index 2529d5847c768a6b1139d135f2847a42fd934b0d..239ac22571b4ae5c4559acc9b0b02474262bc066 100644
--- a/chrome/test/webdriver/commands/command.h
+++ b/chrome/test/webdriver/commands/command.h
@@ -49,9 +49,7 @@ class Command {
// Returns the path variable encoded at the |i|th index (0-based) in the
// request URL for this command. If the index is out of bounds, an empty
// string will be returned.
- inline std::string GetPathVariable(const size_t i) const {
- return i < path_segments_.size() ? path_segments_.at(i) : "";
- }
+ std::string GetPathVariable(const size_t i) const;
// Returns whether the command has a parameter with the given |key|.
bool HasParameter(const std::string& key) const;

Powered by Google App Engine
This is Rietveld 408576698