Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Unified Diff: chrome/browser/automation/automation_provider_observers.cc

Issue 5572001: Send screenshots back to the client for debugging (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: changed PageSnapshotTaker to use JSON interface Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/automation/automation_provider_observers.cc
diff --git a/chrome/browser/automation/automation_provider_observers.cc b/chrome/browser/automation/automation_provider_observers.cc
index 8f5fc1f0a0faa8dfa104e04eff27a831ca1bd7bd..264c6bf4c530e8ecc39e1b7f8e7d10285d63cf85 100644
--- a/chrome/browser/automation/automation_provider_observers.cc
+++ b/chrome/browser/automation/automation_provider_observers.cc
@@ -1732,9 +1732,13 @@ void PageSnapshotTaker::ExecuteScript(const std::wstring& javascript) {
void PageSnapshotTaker::SendMessage(bool success) {
if (automation_) {
- AutomationMsg_CaptureEntirePageAsPNG::WriteReplyParams(reply_message_.get(),
- success);
- automation_->Send(reply_message_.release());
+ if (success) {
+ AutomationJSONReply(automation_, reply_message_.release())
+ .SendSuccess(NULL);
+ } else {
+ AutomationJSONReply(automation_, reply_message_.release())
+ .SendError("Failed to take snapshot of page");
+ }
}
delete this;
}

Powered by Google App Engine
This is Rietveld 408576698