Send screenshots back to the client for debugging

chrome/test/webdriver/session.h

Index: chrome/test/webdriver/session.h
diff --git a/chrome/test/webdriver/session.h b/chrome/test/webdriver/session.h
index 79b0b54ab9f2e7676dee7e47ccec608e2625843b..95e5e437fdb59147ab1925d77a433aa11c60c669 100644
--- a/chrome/test/webdriver/session.h
+++ b/chrome/test/webdriver/session.h
@@ -103,6 +103,7 @@ class Session {
              std::string* cookie);
   bool DeleteCookie(const GURL& url, const std::string& cookie_name);
   bool SetCookie(const GURL& url, const std::string& cookie);
+  bool CaptureEntirePageAsPNG(std::string* png);

[kkania, 2011/03/16 18:19:10]

I see you didn't change this one to GetScreenShot. The idea with the naming is
as following:

Session methods can follow webdriver naming conventions, all Automation methods
do not. That is why Session passes around window_id's everywhere and Automation
passes around tab_id's.

So, it would be ok to use GetScreenshot here, because that is what Webdriver
uses, but better to use CaptureEntirePage in Automation, because that is what
Chrome automation is really doing.

[Joe, 2011/03/17 00:15:25]

Renamed functions
On 2011/03/16 18:19:10, kkania wrote:

 
   // Gets all the currently existing window IDs. Returns true on success.
   bool GetWindowIds(std::vector<int>* window_ids);
@@ -173,18 +174,20 @@ class Session {
   // Waits for all tabs to stop loading. Returns true on success.
   bool WaitForAllTabsToStopLoading();
 
-  inline const std::string& id() const { return id_; }
+  const std::string& id() const;
 
-  inline int implicit_wait() const { return implicit_wait_; }
-  inline void set_implicit_wait(const int& timeout) {
-    implicit_wait_ = timeout > 0 ? timeout : 0;
-  }
+  int implicit_wait() const;
+  void set_implicit_wait(const int& timeout);
 
   enum Speed { kSlow, kMedium, kFast, kUnknown };
-  inline Speed speed() { return speed_; }
-  inline void set_speed(Speed speed) {
-    speed_ = speed;
-  }
+  Speed speed();
+  void set_speed(Speed speed);
+
+  // Since screenshots can be very large when in base64 PNG format; the
+  // client is allowed to dyamically enable/disable screenshots on error
+  // during the lifetime of the session.
+  bool get_screenshot_on_error() const;
+  void set_screenshot_on_error(const bool error);

[kkania, 2011/03/16 18:19:10]

get rid of const before bool here.

[Joe, 2011/03/17 00:15:25]

Done.

 
   const FrameId& current_target() const;
 
@@ -216,6 +219,7 @@ class Session {
   base::Thread thread_;
 
   int implicit_wait_;
+  bool screenshot_on_error_;
   Speed speed_;
 
   FrameId current_target_;