Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(688)

Unified Diff: chrome/test/webdriver/commands/response.cc

Issue 5572001: Send screenshots back to the client for debugging (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: for review Created 9 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/webdriver/commands/response.cc
diff --git a/chrome/test/webdriver/commands/response.cc b/chrome/test/webdriver/commands/response.cc
index 920bad1d8dc55819d4bfae7782eb2d9b7d68ecd4..a869b1729d43734533d8b24d11507b55e6bad4b0 100644
--- a/chrome/test/webdriver/commands/response.cc
+++ b/chrome/test/webdriver/commands/response.cc
@@ -27,6 +27,7 @@ const char* const kStackTraceLineNumberKey = "stackTrace.lineNumber";
Response::Response() {
SetStatus(kSuccess);
SetValue(Value::CreateNullValue());
+ screenshot_ = "";
}
Response::~Response() {}
@@ -60,6 +61,10 @@ void Response::SetError(ErrorCode error_code, const std::string& message,
error->SetString(kStackTraceFileNameKey, file);
error->SetInteger(kStackTraceLineNumberKey, line);
+ if (!screenshot_.empty()) {
+ error->SetString(kScreenKey, screenshot_);
+ }
+
SetStatus(error_code);
SetValue(error);
}
@@ -68,6 +73,10 @@ void Response::SetField(const std::string& key, Value* value) {
data_.Set(key, value);
}
+void Response::SetScreenshot(const std::string& screenshot) {
+ screenshot_ = screenshot;
+}
+
std::string Response::ToJSON() const {
std::string json;
base::JSONWriter::Write(&data_, false, &json);

Powered by Google App Engine
This is Rietveld 408576698