Issue 557021: Prevent excessive crash reporting due stack overflow (due exception in SEH fi...

Issue 557021: Prevent excessive crash reporting due stack overflow (due exception in SEH fi... (Closed)

Created:
10 years, 10 months ago by stoyan

Modified:
9 years, 7 months ago

Reviewers:
amit

CC:
chromium-reviews, amit, Paweł Hajdan Jr.

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Prevent excessive crash reporting due stack overflow (due exception in SEH filter). BUG=32441 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=37673

Patch Set 4 : '' #

Total comments: 4

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+640 lines, -353 lines)			Patch
M	chrome_frame/crash_reporting/crash_report.h	View	1 2 3	2 chunks	+0 lines, -86 lines	0 comments	Download
M	chrome_frame/crash_reporting/crash_report.cc	View	1 2 3	3 chunks	+93 lines, -17 lines	0 comments	Download
M	chrome_frame/crash_reporting/crash_reporting.gyp	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome_frame/crash_reporting/vectored_handler.h	View	1 2 3	1 chunk	+82 lines, -60 lines	0 comments	Download
M	chrome_frame/crash_reporting/vectored_handler-impl.h	View	1 2 3	6 chunks	+139 lines, -21 lines	2 comments	Download
M	chrome_frame/crash_reporting/vectored_handler_unittest.cc	View	1 2 3	1 chunk	+140 lines, -169 lines	1 comment	Download
A	chrome_frame/crash_reporting/veh_test.h	View		1 chunk	+80 lines, -0 lines	0 comments	Download
A	chrome_frame/crash_reporting/veh_test.cc	View		1 chunk	+104 lines, -0 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

amit

a quick look http://codereview.chromium.org/557021/diff/6001/6005 File chrome_frame/crash_reporting/vectored_handler-impl.h (right): http://codereview.chromium.org/557021/diff/6001/6005#newcode134 chrome_frame/crash_reporting/vectored_handler-impl.h:134: namespace { should #ifdef in for ...

10 years, 10 months ago (2010-01-27 23:56:46 UTC) #2

stoyan

http://codereview.chromium.org/557021/diff/6001/6005 File chrome_frame/crash_reporting/vectored_handler-impl.h (right): http://codereview.chromium.org/557021/diff/6001/6005#newcode134 chrome_frame/crash_reporting/vectored_handler-impl.h:134: namespace { On 2010/01/27 23:56:46, amit wrote: > should ...

10 years, 10 months ago (2010-01-30 00:04:54 UTC) #3

amit

10 years, 10 months ago (2010-01-30 00:52:58 UTC) #4

lgtm

http://codereview.chromium.org/557021/diff/7001/8004
File chrome_frame/crash_reporting/vectored_handler-impl.h (right):

http://codereview.chromium.org/557021/diff/7001/8004#newcode182
chrome_frame/crash_reporting/vectored_handler-impl.h:182: static int
StackOverflow() {
static bool StackOverflow()?

http://codereview.chromium.org/557021/diff/7001/8004#newcode183
chrome_frame/crash_reporting/vectored_handler-impl.h:183:
MEMORY_BASIC_INFORMATION mi;
nit: = {0}, just to be safe

http://codereview.chromium.org/557021/diff/7001/8003
File chrome_frame/crash_reporting/vectored_handler_unittest.cc (right):

http://codereview.chromium.org/557021/diff/7001/8003#newcode133
chrome_frame/crash_reporting/vectored_handler_unittest.cc:133: ZeroMemory(tmp,
sizeof(tmp));
call OverflowStack here again, just to be sure? :)

http://codereview.chromium.org/557021/diff/7001/8006
File chrome_frame/crash_reporting/veh_test.cc (right):

http://codereview.chromium.org/557021/diff/7001/8006#newcode71
chrome_frame/crash_reporting/veh_test.cc:71: static LONG WINAPI
VEH(EXCEPTION_POINTERS* exptrs) {
nit: rename to something more intuitive like TestExceptionHandler?

Expand Messages | Collapse Messages