Add cros dir into autotest ebuild.

Add cros dir into autotest ebuild.

Change-Id: I6a96a54035d5291853f1b9f8374d1d8bc7018c86

BUG=
TEST=

Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=52ea5c3

[DaleCurtis, 2010-12-07 17:43:26]

http://codereview.chromium.org/5568008/diff/1/chromeos-base/autotest/autotest...
File chromeos-base/autotest/autotest-9999.ebuild (right):

http://codereview.chromium.org/5568008/diff/1/chromeos-base/autotest/autotest...
chromeos-base/autotest/autotest-9999.ebuild:32: cp -fpru
"${S}"/client/{bin,common_lib,tools} "${AUTOTEST_WORK}/client"
In keeping with style, you should add "cros" here instead of the new cp lines
below. Maybe even move these lists into variables.

http://codereview.chromium.org/5568008/diff/1/chromeos-base/autotest/autotest...
chromeos-base/autotest/autotest-9999.ebuild:34: cp -fpru
"${S}"/server/{bin,control_segments,hosts} "${AUTOTEST_WORK}/server"
Same as above.

[ericli, 2010-12-07 17:47:46]

No, in order to make it clear and make a distinguish, I purposefully
separated them out!

On Tue, Dec 7, 2010 at 9:43 AM, <dalecurtis@chromium.org> wrote:

>
>
>
http://codereview.chromium.org/5568008/diff/1/chromeos-base/autotest/autotest...
> File chromeos-base/autotest/autotest-9999.ebuild (right):
>
>
>
http://codereview.chromium.org/5568008/diff/1/chromeos-base/autotest/autotest...
> chromeos-base/autotest/autotest-9999.ebuild:32: cp -fpru
> "${S}"/client/{bin,common_lib,tools} "${AUTOTEST_WORK}/client"
> In keeping with style, you should add "cros" here instead of the new cp
> lines below. Maybe even move these lists into variables.
>
>
>
http://codereview.chromium.org/5568008/diff/1/chromeos-base/autotest/autotest...
> chromeos-base/autotest/autotest-9999.ebuild:34: cp -fpru
> "${S}"/server/{bin,control_segments,hosts} "${AUTOTEST_WORK}/server"
> Same as above.
>
>
> http://codereview.chromium.org/5568008/
>



-- 
Eric Li
李咏竹
Google Kirkland

[ericli, 2010-12-07 18:14:14]

I just added a comment line in the ebuild file.

On 2010/12/07 17:47:46, ericli wrote:
> No, in order to make it clear and make a distinguish, I purposefully
> separated them out!
> 
> On Tue, Dec 7, 2010 at 9:43 AM, <mailto:dalecurtis@chromium.org> wrote:
> 
> >
> >
> >
>
http://codereview.chromium.org/5568008/diff/1/chromeos-base/autotest/autotest...
> > File chromeos-base/autotest/autotest-9999.ebuild (right):
> >
> >
> >
>
http://codereview.chromium.org/5568008/diff/1/chromeos-base/autotest/autotest...
> > chromeos-base/autotest/autotest-9999.ebuild:32: cp -fpru
> > "${S}"/client/{bin,common_lib,tools} "${AUTOTEST_WORK}/client"
> > In keeping with style, you should add "cros" here instead of the new cp
> > lines below. Maybe even move these lists into variables.
> >
> >
> >
>
http://codereview.chromium.org/5568008/diff/1/chromeos-base/autotest/autotest...
> > chromeos-base/autotest/autotest-9999.ebuild:34: cp -fpru
> > "${S}"/server/{bin,control_segments,hosts} "${AUTOTEST_WORK}/server"
> > Same as above.
> >
> >
> > http://codereview.chromium.org/5568008/
> >
> 
> 
> 
> -- 
> Eric Li
> 李咏竹
> Google Kirkland

[DaleCurtis, 2010-12-07 18:27:48]

LGTM

On 2010/12/07 18:14:14, ericli wrote:
> I just added a comment line in the ebuild file.
> 
> On 2010/12/07 17:47:46, ericli wrote:
> > No, in order to make it clear and make a distinguish, I purposefully
> > separated them out!
> > 
> > On Tue, Dec 7, 2010 at 9:43 AM, <mailto:dalecurtis@chromium.org> wrote:
> > 
> > >
> > >
> > >
> >
>
http://codereview.chromium.org/5568008/diff/1/chromeos-base/autotest/autotest...
> > > File chromeos-base/autotest/autotest-9999.ebuild (right):
> > >
> > >
> > >
> >
>
http://codereview.chromium.org/5568008/diff/1/chromeos-base/autotest/autotest...
> > > chromeos-base/autotest/autotest-9999.ebuild:32: cp -fpru
> > > "${S}"/client/{bin,common_lib,tools} "${AUTOTEST_WORK}/client"
> > > In keeping with style, you should add "cros" here instead of the new cp
> > > lines below. Maybe even move these lists into variables.
> > >
> > >
> > >
> >
>
http://codereview.chromium.org/5568008/diff/1/chromeos-base/autotest/autotest...
> > > chromeos-base/autotest/autotest-9999.ebuild:34: cp -fpru
> > > "${S}"/server/{bin,control_segments,hosts} "${AUTOTEST_WORK}/server"
> > > Same as above.
> > >
> > >
> > > http://codereview.chromium.org/5568008/
> > >
> > 
> > 
> > 
> > -- 
> > Eric Li
> > 李咏竹
> > Google Kirkland