Proposed changes to Pepper 3D API.

ppapi/c/dev/ppb_context_3d_dev.h

Index: ppapi/c/dev/ppb_context_3d_dev.h
===================================================================
--- ppapi/c/dev/ppb_context_3d_dev.h	(revision 0)
+++ ppapi/c/dev/ppb_context_3d_dev.h	(revision 0)
@@ -0,0 +1,28 @@
+// Copyright (c) 2010 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef PPAPI_C_DEV_PPB_CONTEXT_3D_DEV_H_
+#define PPAPI_C_DEV_PPB_CONTEXT_3D_DEV_H_
+
+#include "ppapi/c/pp_bool.h"
+#include "ppapi/c/pp_module.h"
+#include "ppapi/c/pp_resource.h"
+
+#define PPB_CONTEXT_3D_DEV_INTERFACE "PPB_Context3D(Dev);0.1"
+
+struct PPB_Context3D_Dev {
+  PP_Bool (*IsContext3D)(PP_Resource resource);
+
+  int32_t (*Create)(PP_Module module,

[brettw, 2010/12/07 05:51:06]

Generally we put this function first and IsXXX second. This function should
return a PP_Resource or NULL on failure rather than have an out param to match
everything else.

Can you also be sure to provide documentation for each function? In particular:
what is share_context, and what is the format of attrib_list?

+                    int32_t config,
+                    PP_Resource share_context,
+                    const int32_t* attrib_list,
+                    PP_Resource* context);
+
+  int32_t (*BindSurfaces)(PP_Resource context,
+                          PP_Resource draw,
+                          PP_Resource read);
+};
+
+#endif  // PPAPI_C_DEV_PPB_CONTEXT_3D_DEV_H_
Property changes on: ppapi\c\dev\ppb_context_3d_dev.h
___________________________________________________________________
Added: svn:eol-style
   + LF