Proposed changes to Pepper 3D API.

gpu/command_buffer/build_gles2_cmd_buffer.py

 #!/usr/bin/python
 #
 # Copyright (c) 2006-2009 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """code generator for GLES2 command buffers."""
 
 import os
 import os.path
@@ skipping 5186 matching lines @@
   def WritePepperGLES2Interface(self, filename):
     """Writes the Pepper OpenGLES interface definition."""
     file = CHeaderWriter(
         filename,
         "// This interface is used to access common and lite profile OpenGL ES "
         "2.0\n// functions.\n",
         3)
 
     file.Write("#include \"ppapi/GLES2/khrplatform.h\"\n\n")
 
-    file.Write("#define PPB_OPENGLES_DEV_INTERFACE \"PPB_OpenGLES(Dev);2.0\"\n\n")
+    file.Write("#define PPB_GLES2_DEV_INTERFACE \"PPB_GLES(Dev);2.0\"\n\n")
 
     for (k, v) in _GL_TYPES.iteritems():
       file.Write("typedef %s %s;\n" % (v, k))
 
-    file.Write("\nstruct PPB_OpenGLES_Dev {\n")
+    file.Write("\nstruct PPB_GLES2_Dev {\n")
+    file.Write("  // TODO(alokp): Add context argument to all gl functions.\n")

[neb, 2010/12/03 19:27:21]

I think that's an interesting idea. The way it works currently, all these
functions are also exported so there isn't another GL library. If we were to add
context argument here, it would mean that we do need an actual GL library that
puts the current context in TLS and so forth. I like that, it removes the
complexity from our proxy layer. We could also #define all those functions. We
should talk about this today.

[alokp, 2010/12/03 19:39:51]

Yes removing complexity is the goal. TLS should be part of the helper library.
We could either create two helper libraries - gles and egl, or fold them into
one pgl library. I am not a big fan of #define because I ran into nasty issues
while porting OpenSceneGraph.

     for func in self.original_functions:
-      if func.GetInfo('extension'):
+      if func.GetInfo('extension') or func.name == 'SwapBuffers':
         continue
       file.Write("  %s (*%s)(%s);\n" %
                  (func.return_type, func.name,
                   func.MakeTypedOriginalArgString("")))
     file.Write("};\n\n")
 
     file.Close()
 
   def WritePepperGLES2Implementation(self, filename):
     """Writes the Pepper OpenGLES interface implementation."""
@@ skipping 97 matching lines @@
 
     if options.generate_docs:
       gen.WriteDocs("docs/gles2_cmd_format_docs_autogen.h")
 
   if gen.errors > 0:
     print "%d errors" % gen.errors
     sys.exit(1)
 
 if __name__ == '__main__':
   main(sys.argv[1:])