Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(425)

Issue 5566005: Be more careful about exiting inlined functions in a test context. (Closed)

Created:
10 years ago by Kevin Millikin (Chromium)
Modified:
9 years, 7 months ago
Reviewers:
CC:
v8-dev
Visibility:
Public.

Description

Be more careful about exiting inlined functions in a test context. When falling off the end of a function inlined in a test context, we cannot constant fold the test of undefined away. The graph builder assumes that control flow always reaches both branches of a test. Instead, explicitly test and branch on "undefined". Introduce a pair of empty blocks to hold the necessary LeaveInlined instructions. Committed: http://code.google.com/p/v8/source/detail?r=5927

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -7 lines) Patch
M src/hydrogen.cc View 1 chunk +17 lines, -7 lines 0 comments Download
A test/mjsunit/compiler/regress-3260426.js View 1 chunk +36 lines, -0 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698