Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(786)

Issue 5563012: Re-generate extension API docs (Closed)

Created:
10 years ago by gfeher
Modified:
9 years, 7 months ago
Reviewers:
kathyw
CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, pam+watch_chromium.org
Visibility:
Public.

Description

Re-generate extension API docs Fix broken </ br> tags in extension_api.json For the zipfile changes: TBR=kurrik BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=68733

Patch Set 1 #

Patch Set 2 : fix <br>s in the json file #

Patch Set 3 : rebase before commit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/common/extensions/api/extension_api.json View 1 1 chunk +1 line, -1 line 0 comments Download
chrome/common/extensions/docs/examples/extensions/benchmark.zip View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
chrome/common/extensions/docs/examples/extensions/buildbot.zip View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
chrome/common/extensions/docs/examples/extensions/chrome_search.zip View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/common/extensions/docs/experimental.sidebar.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/samples.json View 1 2 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
gfeher
Hi, I see that you have modified the extension docs in: http://codereview.chromium.org/5398002/diff/20001/chrome/common/extensions/docs/experimental.sidebar.html Your removed <br> ...
10 years ago (2010-12-08 21:06:15 UTC) #1
kathyw
I think what we really need to do is change </br> to <br> in extension_api.json, ...
10 years ago (2010-12-08 22:26:40 UTC) #2
gfeher
I went for <br> because there are no slashes in the output html, even if ...
10 years ago (2010-12-08 23:11:38 UTC) #3
kathyw
10 years ago (2010-12-08 23:46:10 UTC) #4
LGTM

I use Linux, too, but I take some shortcuts that make my environment a bit
different. The <br>s show up in the output, though, so we're good.

Powered by Google App Engine
This is Rietveld 408576698