webui settings:...

webui settings:
- Add basic highlighting for search results.
- Allow partial page title search matches.

BUG=59267
TEST=Perform searches in the webui settings window.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=68751

[csilv, 2010-12-08 23:21:18]

+jhawkins for review

[James Hawkins, 2010-12-08 23:30:04]

http://codereview.chromium.org/5562011/diff/1/chrome/browser/resources/option...
File chrome/browser/resources/options/search_page.js (right):

http://codereview.chromium.org/5562011/diff/1/chrome/browser/resources/option...
chrome/browser/resources/options/search_page.js:138: // Generate search text is
a lowercase version of the input text, with any
Something seems grammatically off with this comment sentence.

http://codereview.chromium.org/5562011/diff/1/chrome/browser/resources/option...
chrome/browser/resources/options/search_page.js:148: // Generate a regular
expression and transofmr string for searching the
transform

[csilv, 2010-12-08 23:48:29]

http://codereview.chromium.org/5562011/diff/1/chrome/browser/resources/option...
File chrome/browser/resources/options/search_page.js (right):

http://codereview.chromium.org/5562011/diff/1/chrome/browser/resources/option...
chrome/browser/resources/options/search_page.js:138: // Generate search text is
a lowercase version of the input text, with any
On 2010/12/08 23:30:05, James Hawkins wrote:
> Something seems grammatically off with this comment sentence.

Whoops, indeed!  Done.

http://codereview.chromium.org/5562011/diff/1/chrome/browser/resources/option...
chrome/browser/resources/options/search_page.js:148: // Generate a regular
expression and transofmr string for searching the
On 2010/12/08 23:30:05, James Hawkins wrote:
> transform

Done.

[James Hawkins, 2010-12-09 18:40:15]

LGTM

http://codereview.chromium.org/5562011/diff/5001/chrome/browser/resources/opt...
File chrome/browser/resources/options/search_page.js (right):

http://codereview.chromium.org/5562011/diff/5001/chrome/browser/resources/opt...
chrome/browser/resources/options/search_page.js:241: * Build a list of pages to
search.  Omit the search page.
Builds

http://codereview.chromium.org/5562011/diff/5001/chrome/browser/resources/opt...
chrome/browser/resources/options/search_page.js:241: * Build a list of pages to
search.  Omit the search page.
Omits

[csilv, 2010-12-09 18:55:10]

http://codereview.chromium.org/5562011/diff/5001/chrome/browser/resources/opt...
File chrome/browser/resources/options/search_page.js (right):

http://codereview.chromium.org/5562011/diff/5001/chrome/browser/resources/opt...
chrome/browser/resources/options/search_page.js:241: * Build a list of pages to
search.  Omit the search page.
On 2010/12/09 18:40:15, James Hawkins wrote:
> Omits

Done.

http://codereview.chromium.org/5562011/diff/5001/chrome/browser/resources/opt...
chrome/browser/resources/options/search_page.js:241: * Build a list of pages to
search.  Omit the search page.
On 2010/12/09 18:40:15, James Hawkins wrote:
> Builds

Done.