chrome/browser/policy/config_dir_policy_provider_unittest.cc - Issue 5562002: Refactor FileBasedPolicyProvider, introduce AsynchronousPolicyProvider.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/policy/config_dir_policy_provider_unittest.cc

Issue 5562002: Refactor FileBasedPolicyProvider, introduce AsynchronousPolicyProvider. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: review feedback Created 10 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/policy/config_dir_policy_provider.h ('K') | « chrome/browser/policy/config_dir_policy_provider.cc ('k') | chrome/browser/policy/configuration_policy_provider.h » ('j') | chrome/browser/policy/configuration_policy_provider_mac.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/policy/config_dir_policy_provider_unittest.cc

diff --git a/chrome/browser/policy/config_dir_policy_provider_unittest.cc b/chrome/browser/policy/config_dir_policy_provider_unittest.cc

index 25893da6640a5219eaa5ed00b06fc84b1a9d102c..5d8456cf2bc447a64966b8f2654d31dd8c744c1a 100644

--- a/chrome/browser/policy/config_dir_policy_provider_unittest.cc

+++ b/chrome/browser/policy/config_dir_policy_provider_unittest.cc

@@ -49,7 +49,7 @@ class ConfigDirPolicyLoaderTest

// The preferences dictionary is expected to be empty when there are no files to

// load.

TEST_F(ConfigDirPolicyLoaderTest, ReadPrefsEmpty) {

- ConfigDirPolicyLoader loader(test_dir());

+ ConfigDirPolicyProviderDelegate loader(test_dir());

scoped_ptr<DictionaryValue> policy(loader.Load());

EXPECT_TRUE(policy.get());

EXPECT_TRUE(policy->empty());

@@ -59,7 +59,7 @@ TEST_F(ConfigDirPolicyLoaderTest, ReadPrefsEmpty) {

// dictionary.

TEST_F(ConfigDirPolicyLoaderTest, ReadPrefsNonExistentDirectory) {

FilePath non_existent_dir(test_dir().Append(FILE_PATH_LITERAL("not_there")));

- ConfigDirPolicyLoader loader(non_existent_dir);

+ ConfigDirPolicyProviderDelegate loader(non_existent_dir);

scoped_ptr<DictionaryValue> policy(loader.Load());

EXPECT_TRUE(policy.get());

EXPECT_TRUE(policy->empty());

@@ -71,7 +71,7 @@ TEST_F(ConfigDirPolicyLoaderTest, ReadPrefsSinglePref) {

test_dict.SetString("HomepageLocation", "http://www.google.com");

WriteConfigFile(test_dict, "config_file");

- ConfigDirPolicyLoader loader(test_dir());

+ ConfigDirPolicyProviderDelegate loader(test_dir());

scoped_ptr<DictionaryValue> policy(loader.Load());

EXPECT_TRUE(policy.get());

EXPECT_TRUE(policy->Equals(&test_dict));

@@ -93,7 +93,7 @@ TEST_F(ConfigDirPolicyLoaderTest, ReadPrefsMergePrefs) {

for (unsigned int i = 5; i <= 8; ++i)

WriteConfigFile(test_dict_bar, base::IntToString(i));

- ConfigDirPolicyLoader loader(test_dir());

+ ConfigDirPolicyProviderDelegate loader(test_dir());

scoped_ptr<DictionaryValue> policy(loader.Load());

EXPECT_TRUE(policy.get());

EXPECT_TRUE(policy->Equals(&test_dict_foo));