Refactor FileBasedPolicyProvider, introduce AsynchronousPolicyProvider.

chrome/browser/policy/config_dir_policy_provider.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/policy/config_dir_policy_provider.h"
 
 #include <set>
 
 #include "base/file_util.h"
 #include "base/values.h"
 #include "chrome/common/json_value_serializer.h"
 
 namespace policy {
 
-ConfigDirPolicyLoader::ConfigDirPolicyLoader(const FilePath& config_dir)
-    : FileBasedPolicyProvider::Delegate(config_dir) {
+ConfigDirPolicyProviderDelegate::ConfigDirPolicyProviderDelegate(
+    const FilePath& config_dir)
+    : FileBasedPolicyProvider::ProviderDelegate(config_dir) {
 }
 
-DictionaryValue* ConfigDirPolicyLoader::Load() {
+DictionaryValue* ConfigDirPolicyProviderDelegate::Load() {
   // Enumerate the files and sort them lexicographically.
   std::set<FilePath> files;
   file_util::FileEnumerator file_enumerator(config_file_path(), false,
                                             file_util::FileEnumerator::FILES);
   for (FilePath config_file_path = file_enumerator.Next();
        !config_file_path.empty(); config_file_path = file_enumerator.Next())
     files.insert(config_file_path);
 
   // Start with an empty dictionary and merge the files' contents.
   DictionaryValue* policy = new DictionaryValue;
@@ skipping 12 matching lines @@
       LOG(WARNING) << "Expected JSON dictionary in configuration file "
                    << config_file_iter->value();
       continue;
     }
     policy->MergeDictionary(static_cast<DictionaryValue*>(value.get()));
   }
 
   return policy;
 }
 
-base::Time ConfigDirPolicyLoader::GetLastModification() {
+base::Time ConfigDirPolicyProviderDelegate::GetLastModification() {
   base::Time last_modification = base::Time();
   base::PlatformFileInfo file_info;
 
   // If the path does not exist or points to a directory, it's safe to load.
   if (!file_util::GetFileInfo(config_file_path(), &file_info) ||
       !file_info.is_directory) {
     return last_modification;
   }
 
   // Enumerate the files and find the most recent modification timestamp.
   file_util::FileEnumerator file_enumerator(config_file_path(),
                                             false,
                                             file_util::FileEnumerator::FILES);
   for (FilePath config_file = file_enumerator.Next();
        !config_file.empty();
        config_file = file_enumerator.Next()) {
     if (file_util::GetFileInfo(config_file, &file_info) &&
         !file_info.is_directory) {
       last_modification = std::min(last_modification, file_info.last_modified);
     }
   }
 
   return last_modification;
 }
 
 ConfigDirPolicyProvider::ConfigDirPolicyProvider(
     const ConfigurationPolicyProvider::PolicyDefinitionList* policy_list,
     const FilePath& config_dir)
-    : FileBasedPolicyProvider(policy_list,
-                              new ConfigDirPolicyLoader(config_dir)) {
+    : FileBasedPolicyProvider(
+        policy_list,
+        new ConfigDirPolicyProviderDelegate(config_dir)) {
 }
 
 }  // namespace policy