Refactor FileBasedPolicyProvider, introduce AsynchronousPolicyProvider.

chrome/browser/policy/asynchronous_policy_loader_unittest.cc

+// Copyright (c) 2010 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/browser_thread.h"

[Mattias Nissler (ping if slow), 2010/12/06 10:26:20]

Do you need that header?

[danno, 2010/12/06 14:05:12]

Done.

+#include "chrome/browser/policy/asynchronous_policy_loader.h"
+#include "chrome/browser/policy/asynchronous_policy_provider.h"
+#include "chrome/browser/policy/asynchronous_policy_test_base.h"
+#include "chrome/browser/policy/mock_configuration_policy_provider.h"
+#include "chrome/common/notification_registrar.h"
+#include "chrome/common/notification_service.h"
+#include "chrome/common/notification_source.h"
+#include "chrome/test/mock_notification_observer.h"
+
+using ::testing::_;
+using ::testing::InSequence;
+using ::testing::Return;
+
+namespace policy {
+
+const int kReloadIntervalMinutesForTesting = 1;

[Mattias Nissler (ping if slow), 2010/12/06 10:26:20]

This is unused.

[danno, 2010/12/06 14:05:12]

Done.

+
+class AsynchronousPolicyLoaderTest : public AsynchronousPolicyTestBase {
+ public:
+  AsynchronousPolicyLoaderTest() {}
+  virtual ~AsynchronousPolicyLoaderTest() {}
+
+  virtual void SetUp() {
+    AsynchronousPolicyTestBase::SetUp();
+    mock_provider_ = new MockConfigurationPolicyProvider();
+    provider_.reset(mock_provider_);
+  }
+
+ protected:
+  MockConfigurationPolicyProvider* mock_provider_;  // weak
+
+ private:
+  DISALLOW_COPY_AND_ASSIGN(AsynchronousPolicyLoaderTest);
+};
+
+ACTION(CreateTestDictionary) {
+  return new DictionaryValue();
+}
+
+ACTION_P(CreateSequencedTestDictionary, number) {
+  DictionaryValue* test_dictionary = new DictionaryValue();
+  test_dictionary->SetInteger("id", ++(*number));
+  return test_dictionary;
+}
+
+ACTION(RescheduleImmediatePolicyReload) {
+  *arg1 = base::TimeDelta();
+  return false;
+}
+
+TEST_F(AsynchronousPolicyLoaderTest, InitialLoad) {
+  DictionaryValue* template_dict(new DictionaryValue());
+  EXPECT_CALL(*delegate_, Load()).WillOnce(Return(template_dict));
+  scoped_refptr<AsynchronousPolicyLoader> loader =
+      new AsynchronousPolicyLoader(delegate_.release());
+  loader->Init();
+  const DictionaryValue* loaded_dict(loader->policy());
+  EXPECT_TRUE(loaded_dict->Equals(template_dict));
+}
+
+// Verify that the fallback policy requests are made.
+TEST_F(AsynchronousPolicyLoaderTest, InitialLoadWithFallback) {
+  int dictionary_number = 0;
+  InSequence s;
+  EXPECT_CALL(*delegate_, Load()).WillOnce(
+      CreateSequencedTestDictionary(&dictionary_number));
+  EXPECT_CALL(*delegate_, Load()).WillOnce(
+      CreateSequencedTestDictionary(&dictionary_number));
+  scoped_refptr<AsynchronousPolicyLoader> loader =
+      new AsynchronousPolicyLoader(delegate_.release());
+  loader->Init();
+  loop_.RunAllPending();
+  loader->Reload();
+  loop_.RunAllPending();
+
+  const DictionaryValue* loaded_dict(loader->policy());
+  int loaded_number;
+  EXPECT_TRUE(loaded_dict->GetInteger("id", &loaded_number));
+  EXPECT_EQ(dictionary_number, loaded_number);
+}
+
+// Ensure that calling stop on the loader stops subsequent reloads from
+// happening.
+TEST_F(AsynchronousPolicyLoaderTest, Stop) {
+  ON_CALL(*delegate_, Load()).WillByDefault(CreateTestDictionary());
+  EXPECT_CALL(*delegate_, Load()).Times(1);
+  scoped_refptr<AsynchronousPolicyLoader> loader =
+      new AsynchronousPolicyLoader(delegate_.release());
+  loader->Init();
+  loop_.RunAllPending();
+  loader->Stop();
+  loop_.RunAllPending();
+  loader->Reload();
+  loop_.RunAllPending();
+}
+
+// Verifies that the provider is notified upon policy reload, but only
+// if the policy changed.
+TEST_F(AsynchronousPolicyLoaderTest, ProviderNotificationOnPolicyChange) {
+  InSequence s;
+  MockNotificationObserver observer;
+  //  NotificationService service;
+  NotificationRegistrar registrar;
+  registrar.Add(&observer,
+                NotificationType::POLICY_CHANGED,
+                NotificationService::AllSources());
+  int dictionary_number_1 = 0;
+  int dictionary_number_2 = 0;
+  EXPECT_CALL(*delegate_, Load()).WillOnce(
+      CreateSequencedTestDictionary(&dictionary_number_1));
+  EXPECT_CALL(*delegate_, Load()).WillOnce(
+      CreateSequencedTestDictionary(&dictionary_number_2));
+  EXPECT_CALL(observer, Observe(_, _, _)).Times(0);
+  EXPECT_CALL(*delegate_, Load()).WillOnce(
+      CreateSequencedTestDictionary(&dictionary_number_2));
+  EXPECT_CALL(observer, Observe(_, _, _)).Times(1);
+  EXPECT_CALL(*delegate_, Load()).WillOnce(
+      CreateSequencedTestDictionary(&dictionary_number_1));
+  scoped_refptr<AsynchronousPolicyLoader> loader =
+      new AsynchronousPolicyLoader(delegate_.release());
+  AsynchronousPolicyProvider provider(NULL, loader);
+  loop_.RunAllPending();
+  loader->Reload();
+  loop_.RunAllPending();
+  loader->Reload();
+  loop_.RunAllPending();
+  loader->Reload();
+  loop_.RunAllPending();
+}
+
+}  // namespace policy