Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(431)

Issue 556101: Avoid using RecordWrite with the context (esi, rsi, cp) as... (Closed)

Created:
10 years, 10 months ago by Kasper Lund
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Avoid using RecordWrite with the context (esi, rsi, cp) as one of the arguments since this may clobber the register. Committed: http://code.google.com/p/v8/source/detail?r=3757

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -3 lines) Patch
M src/arm/full-codegen-arm.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/arm/macro-assembler-arm.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/x64/macro-assembler-x64.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Kasper Lund
10 years, 10 months ago (2010-02-01 13:15:28 UTC) #1
Kevin Millikin (Chromium)
LGTM.
10 years, 10 months ago (2010-02-01 13:17:33 UTC) #2
Mads Ager (chromium)
10 years, 10 months ago (2010-02-01 13:17:46 UTC) #3
LGTM!

Powered by Google App Engine
This is Rietveld 408576698