Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Unified Diff: webkit/tools/test_shell/layout_test_controller.cc

Issue 556061: Enable WebGL layout tests. (Closed)
Patch Set: Created 10 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webkit/tools/layout_tests/test_expectations.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/tools/test_shell/layout_test_controller.cc
diff --git a/webkit/tools/test_shell/layout_test_controller.cc b/webkit/tools/test_shell/layout_test_controller.cc
index 7dedc70b053307c3220604e374811ba239ecdf55..1b9c6690eb8a30346aae841e8f713565f839991c 100644
--- a/webkit/tools/test_shell/layout_test_controller.cc
+++ b/webkit/tools/test_shell/layout_test_controller.cc
@@ -903,9 +903,9 @@ bool LayoutTestController::CppVariantToBool(const CppVariant& value) {
return 0 != value.ToInt32();
else if (value.isString()) {
std::string valueString = value.ToString();
- if (valueString == "true")
+ if (valueString == "true" || valueString == "1")
return true;
- if (valueString == "false")
+ if (valueString == "false" || valueString == "0")
return false;
}
LogErrorToConsole("Invalid value. Expected boolean value.");
@@ -991,6 +991,8 @@ void LayoutTestController::overridePreference(
preferences->application_cache_enabled = CppVariantToBool(value);
else if (key == "WebKitTabToLinksPreferenceKey")
preferences->tabs_to_links = CppVariantToBool(value);
+ else if (key == "WebKitWebGLEnabled")
+ preferences->experimental_webgl_enabled = CppVariantToBool(value);
else {
std::string message("Invalid name for preference: ");
message.append(key);
« no previous file with comments | « webkit/tools/layout_tests/test_expectations.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698