Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 556060: Enable building autotests in test loop and sbt script (Closed)

Created:
10 years, 11 months ago by kmixter1
Modified:
9 years, 7 months ago
Reviewers:
sosa
CC:
chromium-os-reviews_chromium.org
Visibility:
Public.

Description

Enable building autotests in test loop and sbt script

Patch Set 1 #

Patch Set 2 : rename autotests to test #

Patch Set 3 : Canonicalize checkout top directory in case of links to make .. safe #

Patch Set 4 : fix 80 chars #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -1 line) Patch
M src/scripts/run_remote_tests.sh View 1 2 3 3 chunks +9 lines, -1 line 1 comment Download
M src/scripts/sync_build_test.sh View 1 2 5 chunks +16 lines, -0 lines 1 comment Download

Messages

Total messages: 3 (0 generated)
kmixter1
10 years, 11 months ago (2010-01-29 02:25:01 UTC) #1
sosa
lgtm with a couple comments http://codereview.chromium.org/556060/diff/5001/6001 File src/scripts/run_remote_tests.sh (right): http://codereview.chromium.org/556060/diff/5001/6001#newcode181 src/scripts/run_remote_tests.sh:181: local results_dir_name="${short_name},${FLAGS_machine_desc},${start_time}" Unless you're ...
10 years, 11 months ago (2010-01-29 02:43:10 UTC) #2
sosa
10 years, 10 months ago (2010-02-02 00:04:32 UTC) #3
sounds good to me

Powered by Google App Engine
This is Rietveld 408576698