Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 556058: Quick hack to make popup shrinkage work again (Closed)

Created:
10 years, 11 months ago by Aaron Boodman
Modified:
9 years, 6 months ago
Reviewers:
Matt Perry
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

The upstream change to make popup shrinking work properly is a big project, so I'm doing a quick hack here so that we don't ship more builds with it broken. BUG=30291 TEST=Install news sample extension. Expand a section, then contract it. Popup should contract too. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=37654

Patch Set 1 #

Patch Set 2 : formatting #

Total comments: 1

Patch Set 3 : Only run timer on extension views #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -2 lines) Patch
M chrome/browser/extensions/extension_host.cc View 1 chunk +6 lines, -2 lines 0 comments Download
M chrome/renderer/render_view.h View 1 2 2 chunks +9 lines, -0 lines 0 comments Download
M chrome/renderer/render_view.cc View 1 2 2 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Aaron Boodman
10 years, 11 months ago (2010-01-28 17:53:57 UTC) #1
Matt Perry
http://codereview.chromium.org/556058/diff/1001/6 File chrome/renderer/render_view.cc (right): http://codereview.chromium.org/556058/diff/1001/6#newcode3342 chrome/renderer/render_view.cc:3342: void RenderView::OnEnablePreferredSizeChangedMode() { What kind of renderers is this ...
10 years, 11 months ago (2010-01-28 19:27:50 UTC) #2
Aaron Boodman
On 2010/01/28 19:27:50, Matt Perry wrote: > http://codereview.chromium.org/556058/diff/1001/6 > File chrome/renderer/render_view.cc (right): > > http://codereview.chromium.org/556058/diff/1001/6#newcode3342 ...
10 years, 11 months ago (2010-01-28 22:42:23 UTC) #3
Matt Perry
10 years, 11 months ago (2010-01-28 22:44:40 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698